Skip to content

PFMs#378

Open
bqrosen wants to merge 28 commits into
masterfrom
PFMs
Open

PFMs#378
bqrosen wants to merge 28 commits into
masterfrom
PFMs

Conversation

@bqrosen

@bqrosen bqrosen commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Pipeline for PROFUMO decomposition. I started from Andrea's Yang's PFMs code, and finished generalizing it in the HCP Pipelines style. I tested in on Mac25Rhesus and Mac25Cyno, and it is working there.

Known issues:
(1) This PR does not include the ./PFM/profumo_v2.sif singularity container, because it is 6.6G.
(2) The full run example script uses Mac25Rhesus rather than something more standard like HCP1071 and has local paths in it.
(3) The matlab needs to be compiled

@bqrosen bqrosen requested review from coalsont and glasserm January 7, 2026 17:45
Comment thread PFM/scripts/PFMNotes.sh Outdated
Comment thread PFM/scripts/PFMNotes.m Outdated
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh Outdated
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh Outdated
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh Outdated
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread PFM/scripts/ImportPFMNotes.m Outdated
Comment thread PFM/scripts/PostPROFUMO.sh
Comment thread PFM/scripts/PFMNotes.m Outdated

@glasserm glasserm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my above comments.

Comment thread PFM/PFMPipeline.sh Outdated
RegName=""
MatlabMode=1
RunLocal=0
QUEUE="matlabparallelhigh.q@brainmappers-desktop3"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your testing purposes, please make a copy of the batch rather than pushing your settings (and paths), even to a branch.

I'm not sure we have any other batch scripts that submit a job that is expected to go highly parallel on each job (the non-longitudinal tICA batch examples are configured to run locally).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the batch script needs to be still needs to be overhauled.. It should probably use HCP_YA task data like fMRIStats does.

Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh
Comment thread PFM/PFMPipeline.sh
Comment thread Examples/Scripts/RunPFMpipelineFullRun.sh
Burke Rosen added 3 commits February 16, 2026 17:41
…ROFUMO input dtseries ciftis to cifti v1 to work around weird PROFUMO file loading bug where it thinks the files aren't the same size.
Comment thread PFM/PFMPipeline.sh Outdated
Comment thread PFM/scripts/GroupPFMs.sh Outdated
Comment thread PFM/scripts/PostPROFUMO.sh Outdated
Comment thread PFM/PFMPipeline.sh
# Validate required PROFUMO parameters
if [[ "$ProfumoConfig" == "" ]]
then
log_Err_Abort "PROFUMO config file must be specified with --profumo-config"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would appear that the user has to write the config file, which must contain the list of subjects (among other things), since it doesn't appear to get passed to profumo in another way. How complicated (or version-dependent) is the config format, and should we consider having the pipeline script generate it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's written by the batch script, which I think offers a little more flexibility for the user than putting it directly in the pipeline script. but I can see the argument for moving it into the pipeline script.

Burke Rosen added 2 commits February 25, 2026 12:06
…, to avoid SIMD buffer alignment issue in PROFUMO if files were written with an older version of cifti-matlab with 8-byte instead of 16-byte alignment.
@glasserm

Copy link
Copy Markdown
Contributor

@bqrosen @coalsont What is pending on this PR?

@bqrosen

bqrosen commented Apr 22, 2026 via email

Copy link
Copy Markdown
Contributor Author

@coalsont

Copy link
Copy Markdown
Member

It doesn't yet support compiled matlab mode, I'd rather not merge it until that is ready. Is Andrea available to finish the edits in the other PR, or do we need a different path forward?

@glasserm

Copy link
Copy Markdown
Contributor

That's fine. We can add it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants