Fix #29: [milestone Milestone 3 ] Wire the gate into make ci so a PR that re-forks a canonical schema fails auto...

[telleroutlook]

Fixes #29

Generated by claude-bot-go worker.

[telleroutlook]

Summary

Additive drift-gate script and Makefile target strengthen CI; logic is sound with no blockers, only minor suggestions.

Severity

low

Blocking findings

1. scripts/check-schema-drift.py:43 Redundant import: get_schema/schema_ids are already imported in main() (line ~73); here both names are actually used so the # noqa: F401 is unnecessary. Consider importing once at module scope guarded by the ImportError check, or dropping the noqa.
2. scripts/check-schema-drift.py:78 Exit code 2 (package not installed) is now surfaced via ci (Makefile:147), so make ci hard-fails in any runner where wasmagent-protocol is absent rather than skipping the gate. Confirm the package is installed in CI, or decide whether a missing package should skip vs fail.
3. scripts/check-schema-drift.py:33 KNOWN_LEGACY_FORKS values (slug strings) are never read — only stem in KNOWN_LEGACY_FORKS key membership is checked. The mapping values are dead data; a set would express intent more clearly.

Verdict

✅ Approved

Merge risk

low

Audit

• model: opus
• effort: high
• tokens: input=0, output=0

{
  "approved": true,
  "severity": "low",
  "summary": "Additive drift-gate script and Makefile target strengthen CI; logic is sound with no blockers, only minor suggestions.",
  "findings": [
    {
      "file": "scripts/check-schema-drift.py",
      "line": 43,
      "issue": "Redundant import: get_schema/schema_ids are already imported in main() (line ~73); here both names are actually used so the `# noqa: F401` is unnecessary. Consider importing once at module scope guarded by the ImportError check, or dropping the noqa.",
      "kind": "suggestion"
    },
    {
      "file": "scripts/check-schema-drift.py",
      "line": 78,
      "issue": "Exit code 2 (package not installed) is now surfaced via `ci` (Makefile:147), so `make ci` hard-fails in any runner where wasmagent-protocol is absent rather than skipping the gate. Confirm the package is installed in CI, or decide whether a missing package should skip vs fail.",
      "kind": "suggestion"
    },
    {
      "file": "scripts/check-schema-drift.py",
      "line": 33,
      "issue": "KNOWN_LEGACY_FORKS values (slug strings) are never read — only `stem in KNOWN_LEGACY_FORKS` key membership is checked. The mapping values are dead data; a set would express intent more clearly.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "low",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}