Fix #27: [milestone Milestone 2 ] Update fixtures/golden/*.jsonl and tests/test_schemas*.py to validate agains... - #40
Merged
Conversation
…d `tests/test_schemas*.py` to validate agains...
Collaborator
Author
SummaryFixture cleanup removing null fields with new schema validation test Severitynone Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "none",
"summary": "Fixture cleanup removing null fields with new schema validation test",
"findings": [
{
"file": "tests/test_schemas_json.py",
"line": 9,
"issue": "New imports (wasmagent_protocol, jsonschema, referencing) added - ensure these dependencies are declared in project configuration",
"kind": "suggestion"
},
{
"file": "tests/test_schemas_json.py",
"line": 205,
"issue": "New test class validates golden fixtures against canonical package schema - verify CI environment has wasmagent-protocol package installed",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 1
} |
Collaborator
Author
SummaryPR safely aligns golden fixtures with canonical wasmagent-protocol schema and adds validation test Severitynone Blocking findingsNone. Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "none",
"summary": "PR safely aligns golden fixtures with canonical wasmagent-protocol schema and adds validation test",
"findings": [],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 2
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
Generated by claude-bot-go worker.