Skip to content

Fix #27: [milestone Milestone 2 ] Update fixtures/golden/*.jsonl and tests/test_schemas*.py to validate agains... - #40

Merged
telleroutlook merged 1 commit into
mainfrom
claude/issue-27
Jul 27, 2026
Merged

Fix #27: [milestone Milestone 2 ] Update fixtures/golden/*.jsonl and tests/test_schemas*.py to validate agains...#40
telleroutlook merged 1 commit into
mainfrom
claude/issue-27

Conversation

@telleroutlook

Copy link
Copy Markdown
Collaborator

Fixes #27

Generated by claude-bot-go worker.

…d `tests/test_schemas*.py` to validate agains...
@telleroutlook

Copy link
Copy Markdown
Collaborator Author

Summary

Fixture cleanup removing null fields with new schema validation test

Severity

none

Blocking findings

  1. tests/test_schemas_json.py:9 New imports (wasmagent_protocol, jsonschema, referencing) added - ensure these dependencies are declared in project configuration
  2. tests/test_schemas_json.py:205 New test class validates golden fixtures against canonical package schema - verify CI environment has wasmagent-protocol package installed

Verdict

✅ Approved

Merge risk

low

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": true,
  "severity": "none",
  "summary": "Fixture cleanup removing null fields with new schema validation test",
  "findings": [
    {
      "file": "tests/test_schemas_json.py",
      "line": 9,
      "issue": "New imports (wasmagent_protocol, jsonschema, referencing) added - ensure these dependencies are declared in project configuration",
      "kind": "suggestion"
    },
    {
      "file": "tests/test_schemas_json.py",
      "line": 205,
      "issue": "New test class validates golden fixtures against canonical package schema - verify CI environment has wasmagent-protocol package installed",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "low",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

@telleroutlook

Copy link
Copy Markdown
Collaborator Author

Summary

PR safely aligns golden fixtures with canonical wasmagent-protocol schema and adds validation test

Severity

none

Blocking findings

None.

Verdict

✅ Approved

Merge risk

low

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": true,
  "severity": "none",
  "summary": "PR safely aligns golden fixtures with canonical wasmagent-protocol schema and adds validation test",
  "findings": [],
  "merge_risk": "low",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 2
}

@telleroutlook
telleroutlook merged commit 509f8d5 into main Jul 27, 2026
5 checks passed
@telleroutlook
telleroutlook deleted the claude/issue-27 branch July 27, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[milestone Milestone 2 ] Update fixtures/golden/*.jsonl and tests/test_schemas*.py to validate agains...

1 participant