This repository was archived by the owner on Apr 24, 2026. It is now read-only.
Send feedback to Plausible - #2
Open
rubenvanerk wants to merge 2 commits into
Open
Conversation
nikini
suggested changes
Jun 9, 2025
| onVote(id); | ||
| } | ||
|
|
||
| if (typeof plausible === 'function') { |
Member
There was a problem hiding this comment.
I think this should be in the onVote function wherever it's used - just to keep the component away from a script that can potentially not exist.
However, a change would still be needed so that onVote also passed the code and the resourceId, maybe as a second param object that contains "extra" data
Member
|
@rubenvanerk What's up with this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we could get some really cool insights if we send the feedback to Plausible. For example we could compare how many people go vegan after watching the 3mmc in France vs Germany.
It would be nice if we can get the (English) label here for the feedback option and resource instead of the ids. Not sure on how to do that though.
We can also use a css class approach here, but I think that can get messy: https://plausible.io/docs/custom-event-goals#step-3-add-a-css-class-name-to-the-element-you-want-to-track-on-your-site