feat; [Test] Assert fee math prevents zero-loss rounding errors#447
Open
Happybello365 wants to merge 3 commits into
Open
feat; [Test] Assert fee math prevents zero-loss rounding errors#447Happybello365 wants to merge 3 commits into
Happybello365 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If fees calculate rounding errors, token fragments become permanently stranded representing lost capital value.
Explicit Expectations
Spin test paths confirming math where splits involve odd un-divisible token subsets.
Ensure the protocol absorbs loss fragments rather than sticking users.
Acceptance Criteria
Dust tokens settle predictably on the protocol balancing variables.
Contributor checklist:
Ensure the project builds successfully.
Add or update tests for all new/changed logic.
Make sure all tests pass.
Run the formatter / linter so code is properly formatted and consistent.
closes #349