Skip to content

Implement protocol fee aggregation and admin claim to treasury#448

Merged
Akshola00 merged 1 commit into
Web3Novalabs:mainfrom
NueloSE:feat/claim-protocol-fees
May 20, 2026
Merged

Implement protocol fee aggregation and admin claim to treasury#448
Akshola00 merged 1 commit into
Web3Novalabs:mainfrom
NueloSE:feat/claim-protocol-fees

Conversation

@NueloSE
Copy link
Copy Markdown
Contributor

@NueloSE NueloSE commented Apr 28, 2026

Summary

Implements protocol fee aggregation and admin claim functionality as described in #348:

  • Adds an internal unclaimed_fees accumulator to track protocol fees (1% of each donation).
  • Updates donate to deduct and accumulate protocol fees separately from pool allocations.
  • Implements claim_protocol_fees allowing protocol admins to transfer all accumulated fees to a treasury address via the token contract.
  • Ensures fee tracking is fully isolated from pool allocations and student claims.
  • Adds and updates comprehensive tests for all new logic.
  • Ensures build, tests, and formatting requirements are satisfied.

Acceptance Criteria:

  • Fee tracking is isolated from pool allocations.
  • Admins can claim all accumulated fees to a treasury address.
  • Project builds, tests pass, and code is formatted.

Closes

close #348

@Akshola00 Akshola00 merged commit 2d3a370 into Web3Novalabs:main May 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fees] Implement 'claim_protocol_fees' to treasury

2 participants