Refactor filesystem tests to have a root directory#264
Merged
Conversation
This commit is a refactor of all filesystem tests and their configuration to have only a single root directory instead of a list of preopened directories. The purpose of this change is to start moving in the direction of "there's just a root filesystem for WASI guests" as opposed to guests having a set of preopened directories they get to choose from. Tests are refactored in how they access preopened directories and search around for them. The JSON configuration of `dirs` is now just `root` and is optionally specified like before. Additionally passing the name of the first preopen as an argument is now no longer necessary so that's removed too.
andreiltd
approved these changes
Jun 18, 2026
Collaborator
|
The |
Collaborator
Author
|
I tested this locally against a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a refactor of all filesystem tests and their configuration to have only a single root directory instead of a list of preopened directories. The purpose of this change is to start moving in the direction of "there's just a root filesystem for WASI guests" as opposed to guests having a set of preopened directories they get to choose from. Tests are refactored in how they access preopened directories and search around for them. The JSON configuration of
dirsis now justrootand is optionally specified like before. Additionally passing the name of the first preopen as an argument is now no longer necessary so that's removed too.