move signify repository into keria #398

lenkan · 2025-11-05T15:19:49Z

Per discussion on discord.

This PR moves the signify-ts into keria repository. I have included the commit history from signify-ts repository my merging with "--allow-unrelates-histories". The purpose is to use signify-ts as a reference client implementation, they are to be released and tested together as a unit.

Taken from latest main on signify-ts
Runs integration tests on every PR and push closes Proposal: run integration tests on PR #233
Publish workflow that creates dev tags on push to main and releases on workflow_dispatch, supersedes Setup automatic docker build and publish to docker registry #394
- Docker tag: weboftrust/keria:x.y.z-dev.abc123
- Npm version: signify-ts:x.y.z-dev.abc123

Potential todos, can also be subsequent PRs

Update documentation.
Fix integration tests.

The failing integration tests are probably also failing on signify-ts if they would run against latest keria. So I am not sure if that needs to be part of this PR. I have fixed the tests on another branch, but it contains a lot more changes that we probably do not want to add without reviewing.

When I set up the docker-compose, I opted for using network_mode: host. This enable you to switch between running keria or the witness-demo as containers, or locally, without updating any configuration or setting environment variables. On docker desktop, you might have to enable this.

Add in attachment serialization functions

…ex-script add script for single issuer and single holder ipex

Update challenge.ts

remove unused dependencies, move dev dependencies

…oint Remove name param from Credentials.list()

Multisig grant and admit messages and fixes in seqner

Signed-off-by: arshdeep singh <arsh.binny@gmail.com>

use esbuild, tsc and eslint instead of tsdx

…entials-ipex Update an integration example for credentials to support ipex

add join function in groups class to join multisig rotation event

running integration tests

add runInBand to avoid concurrency issues add salty, external module tests

* spike: Feasibility of generating Signify types from Python type hints via OpenAI * add and use generated TS types * demo generated types for credentials().get() * update types for CredentialState * resolve review comments * fix credentials types + add registries's types * Add more types for credentialing * resolve review comments * fix errors/warning for swagger validator * re-generate types * re-generate types * remove debug logs and add multiple overload signatures * separate generate:types and build * fix formatting * use the node.js API instead of starting a child process for generating openAPI types * remove unuse schemas * resolve review comment: fix the eslint rules * update package-lock.json * update types since keria changed * update new types from keria * aiding.py type hints and auto-generated OpenAPI specs * Generate types for Group Member * resolve review comments * fix mock data for aiding test * resolve review comments * resolve review comments * convert old mockdata + recreate KEL types (all fields are required) * rebase and update code * remove unuse test file * update keria api schema * fix audit * resolve review comments: improve ts types for tests of aiding

codecov · 2025-11-05T15:22:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.54%. Comparing base (1f22907) to head (a51123e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   86.60%   86.54%   -0.07%     
==========================================
  Files          25       25              
  Lines        5286     5298      +12     
==========================================
+ Hits         4578     4585       +7     
- Misses        708      713       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iFergal · 2025-11-05T15:30:01Z

I have never done this but it might be worth experimenting to see if there's a way to merge the git histories. From a quick search, there seems to be a few options. Any thoughts?

iFergal · 2025-11-05T15:37:56Z

The failing integration tests are probably also failing on signify-ts if they would ron against latest keria. So I am not sure if that needs to be part of this PR. I have fixed the tests on another branch, but it contains a lot more changes that we probably do not want to add without reviewing.

Agreed. Either we can do it after, or fix Signify on the main branch now.

With respect to other changes: As both a sanity and security check, I'd like to take a hash of the signify-ts repo directory locally and compare against the new directory being introduced here. So I would avoid updating anything inside the folder (e.g. docs) until another PR. cc @m00sey @kentbull

lenkan · 2025-11-05T16:04:30Z

With respect to other changes: As both a sanity and security check, I'd like to take a hash of the signify-ts repo directory locally and compare against the new directory being introduced here. So I would avoid updating anything inside the folder (e.g. docs) until another PR.

I have removed package-lock.json and used in the root instead. Also fixed the linting config. But I can revert both of those changes. Otherwise a hash of the src directory would maybe suffice.

iFergal · 2025-11-05T16:10:18Z

Otherwise a hash of the src directory would maybe suffice.

Sure, that works for me!

…ify-repository

lenkan · 2025-11-06T09:18:01Z

@iFergal I have now included the commit history from signify-ts.

…eType' object has no attribute 'ked' (WebOfTrust#379)" This reverts commit 47e424b.

iFergal

I've done a diff against signify-ts main and all LGTM!

iFergal · 2025-11-07T14:59:49Z

.github/workflows/publish.yml

+
+      - name: Extract version
+        run: |
+          echo "VERSION=$(./version.sh)" >> $GITHUB_ENV


In case we deploy a release a new version of KERIA that has no changes in Signify - will npm artifacts get overiden with newer builds? And vice versa

NPM does not allow overwriting, you'd have to change the version. In the particular case you mentioned both signify and keria would get a new release (I.e. x.y.z-dev.commitsha). In case of 'latest' releases, you'd have to increment the version in pyproject.toml between each publish.

OK - docker registries probably do though right? (in case Signify is bumped but not KERIA)

Yes, Docker hub and GHCR does anyway. But, just to be clear, the workflow I wrote for publishing will use the same version for signify-ts and keria.

Right, I looked a bit too quickly and didn't realise it was applied to both.

Won't that become problematic if we want semantic versioning on APIs? I don't expect every PR will have KERIA and Signify changes - there may be bug fixes or breaking changes in either that don't impact the other (or aren't breaking, for example)

src/keria/app/ipexing.py

kentbull · 2025-11-26T14:14:04Z

Do we want to do one last release of KERIA and Signify with all latest changes before we do this merge?

The delegation fixes I have in a draft PR to KERIpy 1.2.7, that also need to go in to main and 1.3.2, need to be merged to KERIpy, then a new KERIA version with the new KERIpy version.

What do you think about us doing all of that and then merging this? I like the idea of processing all in-flight work, except ESSR and maybe some old PRs, and then doing this repo merge.

lenkan · 2025-12-04T09:52:15Z

Do we want to do one last release of KERIA and Signify with all latest changes before we do this merge?

The delegation fixes I have in a draft PR to KERIpy 1.2.7, that also need to go in to main and 1.3.2, need to be merged to KERIpy, then a new KERIA version with the new KERIpy version.

What do you think about us doing all of that and then merging this? I like the idea of processing all in-flight work, except ESSR and maybe some old PRs, and then doing this repo merge.

Fine by me. I will wait doing any rebasing until then so I don't duplicate work. It's not very complicated though. Biggest problem was failing integration tests in signify-ts. If we can ensure that the tests pass against the release, this PR will be even easier to re-create as no source or test code will have to change.

lenkan and others added 30 commits November 8, 2023 09:44

Merge pull request #1 from kentbull/single-issuer-holder-ipex-script

d966d45

Add in attachment serialization functions

add credentials query and print credential

30324cc

fix formatting with prettier

f10b8bb

fix credentialing test

c0137c9

add tests for utils serializers

244aafa

Merge pull request WebOfTrust#126 from lenkan/single-issuer-holder-ip…

9f020f2

…ex-script add script for single issuer and single holder ipex

remove unused dependencies, move dev dependencies

8cd2ad4

Merge pull request WebOfTrust#125 from nkongsuwan/patch-1

d5e041a

Update challenge.ts

Merge pull request WebOfTrust#128 from lenkan/remove-unused-dependencies

031fde6

remove unused dependencies, move dev dependencies

copied

769a5e0

fix seqner

96dcc49

fix tholder test

38f7cdf

test coverage

3a41dce

Remove name param from Credentials.list()

7a378f4

Merge pull request WebOfTrust#135 from kentbull/credential-query-endp…

a9cc5b9

…oint Remove name param from Credentials.list()

Merge pull request WebOfTrust#133 from rodolfomiranda/grant_admit

370d7b8

Multisig grant and admit messages and fixes in seqner

use esbuild, tsc and eslint instead of tsdx

4de1c27

Update credentials.ts

f72cc72

update example script to support ipex

556d47c

Clarify test flow with better logs and readable names

cd401c2

add join function in groups class to join multisig rotation event

be31b15

Signed-off-by: arshdeep singh <arsh.binny@gmail.com>

Merge pull request WebOfTrust#134 from lenkan/tsc-2

8b9622a

use esbuild, tsc and eslint instead of tsdx

Merge pull request WebOfTrust#137 from nkongsuwan/update-example-cred…

02ffe8f

…entials-ipex Update an integration example for credentials to support ipex

Merge pull request WebOfTrust#139 from Arsh-Sandhu/migrate-scripts

645d665

add join function in groups class to join multisig rotation event

fix single issuer holder script

8cbaab3

fix: remove name parameter from exchanges.get method

27faca2

fix multisig.ts usage - remove name param (#2)

bcd83fc

Draft for running integration tests

e972f8f

Merge pull request WebOfTrust#143 from lenkan/test-integration

e5d39b9

running integration tests

add witness and randy integration tests

f1585fc

add runInBand to avoid concurrency issues add salty, external module tests

lenkan force-pushed the move-signify-repository branch from 6ca00cc to 90d30ec Compare November 5, 2025 15:20

lenkan force-pushed the move-signify-repository branch from 90d30ec to 1f053bd Compare November 5, 2025 15:23

lenkan added 3 commits November 6, 2025 09:43

move files to prepare for repository move

6f88b5b

Merge remote-tracking branch 'signify-ts/move-signify' into move-sign…

af18bec

…ify-repository

chore: adapt workflows to merged repository

92be709

lenkan force-pushed the move-signify-repository branch from 1f053bd to 92be709 Compare November 6, 2025 09:16

lenkan marked this pull request as ready for review November 6, 2025 09:26

lenkan mentioned this pull request Nov 6, 2025

Setup automatic docker build and publish to docker registry #394

Open

lenkan force-pushed the move-signify-repository branch from 19d1d66 to d35f8e2 Compare November 6, 2025 10:05

lenkan added 2 commits November 6, 2025 11:44

fix: running tests on host network only

435e8a8

Revert "fix: KERIA server exits (exit code 1) on admit call with 'Non…

7faad76

…eType' object has no attribute 'ked' (WebOfTrust#379)" This reverts commit 47e424b.

lenkan force-pushed the move-signify-repository branch 7 times, most recently from fd4641e to 64eda44 Compare November 6, 2025 13:14

fix: add retry for registry list

a51123e

lenkan force-pushed the move-signify-repository branch from 64eda44 to a51123e Compare November 6, 2025 13:24

iFergal reviewed Nov 7, 2025

View reviewed changes

move signify repository into keria #398

Are you sure you want to change the base?

move signify repository into keria #398

Uh oh!

Conversation

lenkan commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iFergal commented Nov 5, 2025

Uh oh!

iFergal commented Nov 5, 2025

Uh oh!

lenkan commented Nov 5, 2025

Uh oh!

iFergal commented Nov 5, 2025

Uh oh!

lenkan commented Nov 6, 2025

Uh oh!

iFergal left a comment

Choose a reason for hiding this comment

Uh oh!

iFergal Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lenkan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

iFergal Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lenkan Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

iFergal Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kentbull commented Nov 26, 2025

Uh oh!

lenkan commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

lenkan commented Nov 5, 2025 •

edited

Loading

codecov bot commented Nov 5, 2025 •

edited

Loading