Add the option to clear multiple notifications wit the same tag pattern#13
Open
shiloSaadon wants to merge 4 commits intoWes1324:mainfrom
Open
Add the option to clear multiple notifications wit the same tag pattern#13shiloSaadon wants to merge 4 commits intoWes1324:mainfrom
shiloSaadon wants to merge 4 commits intoWes1324:mainfrom
Conversation
Wes1324
requested changes
Jun 3, 2025
Owner
Wes1324
left a comment
There was a problem hiding this comment.
Thanks a lot for taking the time to make this PR @shiloSaadon. I really appreciate it.
I've just made a few minor suggestions, mainly to make the documentation slightly clearer.
Also, have you managed to test this on both iOS and Android?
| @@ -1,33 +1,39 @@ | |||
| ## 3.0.1 | |||
|
|
|||
| Add the option to clear multiple notifications that their tag contains given pattern | |||
Owner
There was a problem hiding this comment.
Minor but I think this needs a hyphen at the start too
| That option allows you to create grouped notifications by sending notification with `tag` / `apns-collapse-id` that contains specific pattern and than clean all of them at once | ||
|
|
||
| ```javascript | ||
| const notificationTag: string = someGroupId + "_" + messageUUid; |
Owner
There was a problem hiding this comment.
Suggested change
| const notificationTag: string = someGroupId + "_" + messageUUid; | |
| const notificationTag: string = someGroupId + "_" + messageUuid; |
|
|
||
| ## Clear by pattern | ||
|
|
||
| In case you want to clear "group" of notifications you can use `clearAppNotificationsByTagThatContains` |
Owner
There was a problem hiding this comment.
Suggested change
| In case you want to clear "group" of notifications you can use `clearAppNotificationsByTagThatContains` | |
| If you want to clear a "group" of notifications you can use `clearAppNotificationsByTagThatContains` |
| Eraser.clearAppNotificationsByTagThatContains(idGroup); | ||
| ``` | ||
|
|
||
| That option allows you to create grouped notifications by sending notification with `tag` / `apns-collapse-id` that contains specific pattern and than clean all of them at once |
Owner
There was a problem hiding this comment.
Suggested change
| That option allows you to create grouped notifications by sending notification with `tag` / `apns-collapse-id` that contains specific pattern and than clean all of them at once | |
| This feature lets you group notifications by using a `tag` (on Android) or `apns-collapse-id` (on iOS) with a specific pattern. Later, you can use that same pattern to clear all notifications in the group at once. |
| } | ||
| } | ||
|
|
||
| /// Clears all push notifications that have been received by your Flutter app that container the specified pattern in their [tag]. |
Owner
There was a problem hiding this comment.
Suggested change
| /// Clears all push notifications that have been received by your Flutter app that container the specified pattern in their [tag]. | |
| /// Clears all push notifications that have been received by your Flutter app that contain the specified pattern in their [tag]. |
| name: eraser | ||
| description: A flutter plugin that allows remote push notifications to be dismissed and the iOS badge count to be reset. | ||
| version: 3.0.0 | ||
| version: 3.0.1 |
Owner
There was a problem hiding this comment.
I think this should be 3.1.0, and the version in the CHANELOG updated too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In apps like "WhatsApp" when you enter specific chat they clear all the notifications from that specific chat, now you can achieve this using the package by creating tag that contains the group id + uuid and simply clear all the notifications that contains the group id