Guard StormDNS upstream boundary#21
Closed
AmirrezaFarnamTaheri wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR establishes and enforces a “black-box upstream” boundary for the StormDNS engine, preventing accidental edits to the StormDNS submodule contents unless explicitly allowed via a PR label.
Changes:
- Added a guard script to detect changes under
third_party/StormDNS. - Added a GitHub Actions workflow that blocks PRs modifying StormDNS unless labeled
allow-stormdns-upstream. - Documented the allowed integration surface and enforced LF normalization for shell scripts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/check-stormdns-boundary.sh |
New reusable detector for changes under third_party/StormDNS. |
docs/STORMDNS_UPSTREAM_POLICY.md |
Defines allowed/disallowed coupling and the label-based exception process. |
.github/workflows/stormdns-boundary.yml |
CI gate for PRs that touch StormDNS without the allow label. |
.gitattributes |
Forces LF line endings for *.sh to keep CI consistent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+45
| if scripts/check-stormdns-boundary.sh "${base_ref}" "${head_ref}"; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| if [[ "${HAS_UPSTREAM_LABEL}" == "true" ]]; then | ||
| echo "StormDNS upstream changes are intentionally labeled." | ||
| exit 0 | ||
| fi | ||
|
|
||
| exit 1 |
Comment on lines
+12
to
+13
| changed_files="$( | ||
| git diff --name-only "${base_ref}...${head_ref}" -- 'third_party/StormDNS' || true |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/STORMDNS_UPSTREAM_POLICY.md.third_party/StormDNS.allow-stormdns-upstreamlabel.Verification
git diff --cached --check.third_party/StormDNSchanges are detected for this branch.