Improve runtime launch and proxy bridge safety#39
Open
AmirrezaFarnamTaheri wants to merge 3 commits into
Open
Conversation
Prune stale persisted launch request files before saving new proxy or VPN starts. Delete consumed launch request files when proxy and VPN services stop, fail before a stable start, or are replaced by a newer session while preserving active-session requests for recovery reconnects. Avoid blank service session IDs on redelivered or malformed starts and report missing server profile starts through runtime state instead of throwing synchronously from callers. Add JVM coverage for stale request selection and pruning.
Replace unbounded HTTP proxy bridge client and tunnel threads with bounded executors, explicit capacity controls, and lightweight bridge statistics. Reject over-capacity clients with a 503 response, enforce header and host limits, and clean up executors if startup fails before the listener binds. Normalize SOCKS authentication so blank credentials disable auth, and require usable credentials before allowing LAN-reachable HTTP proxy listeners.
Resolve SOCKS authentication through truncated username and password values before applying the enabled flag. This keeps blank or truncated credentials from satisfying LAN-exposure protection and lets the runtime/proxy branch merge cleanly with setup validation changes.
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification