Add Android debug CI checks#51
Open
poulcarlsen53 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds a small Android CI workflow for regular PR and main-branch checks:
\nexplicitly instead of platform-specific newlinesWhy
Before this, the only pull request workflow guarded the StormDNS upstream boundary. Gradle test or packaging regressions could merge without a signal. While testing this locally on Windows, the scan resolver test also exposed a newline portability issue, so this PR fixes that instead of weakening the test.
I intentionally left
lintDebugout of this first workflow because the current tree already has lint errors. Adding lint here would make the new required check fail before this PR changes anything meaningful about lint.Verification
./gradlew :app:testDebugUnitTest --no-daemon./gradlew :app:compileDebugAndroidTestKotlin --no-daemon./gradlew :app:testDebugUnitTest :app:assembleDebug --no-daemon --stacktraceNote:
./gradlew :app:lintDebug :app:assembleDebug --no-daemoncurrently fails on existing Compose lint errors such asLocalContextGetResourceValueCallinWhiteDnsScreen.kt.