test(reports): add vitest and cover comparison-window logic#47
Merged
Conversation
The report deltas relied on windows() to derive the current and prior comparison periods, but nothing tested it and CI ran no unit tests. - Extract windows() into a prisma-free module so it can be imported without instantiating the Prisma client. - Add vitest and cover the explicit-range and trailing-30-days branches, including single-day ranges and one-sided bounds. - Add a Test job to CI and require it in the aggregate ci gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
windows()(report comparison-period logic) into a prisma-free module so it can be imported without instantiating the Prisma client.Testjob to CI and require it in the aggregatecigate.Why
The report deltas depend on
windows()to derive current and prior periods, but nothing tested it and CI ran no unit tests. Closes the first gap flagged in the post-merge analysis.Verification
npm test(6 passing),npm run lint -- --max-warnings 0,npx tsc --noEmitall green locally.