Conversation
mod_ids.len() + 1 / n evaluated as mod_ids.len() + (1/n) due to operator precedence. Integer division made 1/n always 0, so chunks were never split. Fixed to (mod_ids.len() + 1) / n.
remove_mods() was identical to uninstall_mods() — a duplicate alias calling the same Tauri command. Removed it and updated all call sites. Cleaned up stray console.log from invokes.ts, ModCard, DownloadModTab, and DashboardView.
UpdateModTab (476 to 211 lines) and RemoveModTab (398 to 148 lines) shared ~70% identical code: mod grid template, selection logic, getTagStyle, and 170+ lines of duplicated CSS. Extracted into ModGrid.vue with slots for bulk-actions and per-mod-actions. Each tab now contains only its unique logic.
mod_analyzer/src/de.rs and steam-api/src/de.rs contained nearly identical deserialize_u64 implementations. steam-api/de.rs is now the single source of truth for deserialize_bool and deserialize_u64. mod_analyzer/de.rs is now a 4-line re-export. Removed old flexible_u64_deserializer name. Also removed 105 lines of commented-out legacy code from steam-api/build.rs.
build.rs: .expect() on write_built_file() now uses ? operator. lib.rs: .expect() on tauri::Builder::run() now uses .map_err(|e| e.to_string())?. commands.rs: documented hardcoded BUILT_TIME_UTC slice index with format comment.
Added *.pdb and *.dwarf to .gitignore for Rust debug symbols. Removed unused std::convert::Into import from once.rs.
Ran cargo fmt across the workspace. Also fixed a syntax error introduced in the previous commit: missing .into() and trailing comma on the commit field in get_build_info.
Old impl used fs_extra bulk delete with no per-item handling. Mods without home_dir were silently skipped. New impl uses HashSet lookup, per-item fs::remove_dir_all, explicit handling for missing paths, logging on every operation, and partial success reporting with specific failure reasons.
Inner quotes for publishedfileid and file_size aliases were unescaped after the deserializer rename, breaking the build.
home_dir is Option<String>, not Option<PathBuf>. Called .exists() and fs::remove_dir_all on String which doesn't have those methods. Now converts via Path::new() first.
Added three new Tauri commands for profile management: - create_mod_list: captures current enabled mods as a named profile XML - delete_mod_list: removes a profile XML file - apply_mod_list: activates a profile by rewriting config_player.xml Also added helper methods to BarotraumaModManager: mod_list_dir(), player_config_file(), save_mod_list(), delete_mod_list().
New ProfilesTab.vue with: - List existing profiles as cards (name, base package, mod count) - Save Current Mods button to create a profile from enabled mods - Apply button to activate a profile (rewrites game config) - Delete button with confirmation dialog - Full i18n support (EN + ZH) Registered as 4th tab in ModManagementTabs. Added invoke wrappers for create_mod_list, delete_mod_list, apply_mod_list.
- reqwest 0.12 -> 0.13 (enable form feature) - quick-xml 0.38 -> 0.40 - directories-next -> directories v6 - once_cell, fs_extra removed - bump all crate versions to latest compatible
- decode_and_unescape_value -> decoded_and_normalized_value - pass XmlVersion::Implicit1_0 for XML 1.0 normalization
- once_cell::sync::Lazy -> std::sync::LazyLock (edition 2024) - fs_extra::copy_items -> std::fs recursive copy helper - directories_next::BaseDirs -> directories::BaseDirs v6 - &PathBuf -> &Path in set_home_dir signature
- steamcmd-rs: into_iter -> iter on slice, remove clone on Copy type
- mod_analyzer/manage: filter().next_back() -> rfind()
- mod_analyzer/mod_analyzer: rename from_str -> from_xml_string
- mod_analyzer: ok_or_else(|| "") -> ok_or("")
- mod_analyzer/build.rs: &vec![] -> &[]
- transmission: inline format!, &Vec -> &[T], add AttrPair alias
- mod_list.rs: remove empty line after doc comment
- Mark profile system and workshop integration as complete - Add undocumented features (settings, themes, i18n, hashing, etc.) - Add roadmap for future work (drag-drop, true updates, conflict detection)
- set_active_profile / clear_active_profile - check_mod_updates with hash-diff comparison - reorder_enabled_mods with ID validation - rename_profile / compare_profiles / export_profile / import_profile - detect_mod_conflicts with dependency parsing - check_workshop_updates for update notifications - check_network_status for offline detection - get_popular_mods for workshop browsing - write_regularpackages helper to deduplicate XML logic - backup_player_config for auto-backup before profile apply - parse_dependencies + ModDependency in mod_analyzer
- active_profile computed ref and set/clear commands - check_mod_updates with ModUpdateStatus type - reorder_enabled_mods invoke - profile rename/compare/export/import invokes - detect_mod_conflicts with ConflictReport type - check_workshop_updates / check_network_status / get_popular_mods - all zh/en i18n keys for new features
- Mark all roadmap items as complete - Reorganize into Core / UI&UX / Technical sections - Remove Roadmap section (all items shipped)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.