Implemented lyrics button on player to fetch and display song lyrics#111
Draft
Wikijito7 wants to merge 4 commits into
Draft
Implemented lyrics button on player to fetch and display song lyrics#111Wikijito7 wants to merge 4 commits into
Wikijito7 wants to merge 4 commits into
Conversation
…committed poc/ directory
… lyricsConfigured flag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Solves #110
📋 Changelist Summary
Added a lyrics button (📝) to the player that fetches and displays song lyrics using LavaLyrics + LavaSrc (Deezer + LrcLib), with auto-follow on track changes and toggle on/off behavior.
💬 Description
LyricsServicewrapping LavaLyrics'LyricsManagerwithregisterLyricsManager(),loadLyrics(), andgetFormattedLyrics()AudioSourceManagerandLrcLibLyricsManageras lyrics providers inAudioPlayerManagerProviderPLAYER_LYRICScomponent and 📝 button to the player action rowPlayerCommand.onInteract(): first click sends public lyrics + auto-follows track changes, second click deletes itlyricsMessagefield inGuildLavaPlayerServicewithupdateLyricsMessage()inonTrackStart()and cleanup on disconnectCommandHandlerServicerouting forPLAYER_LYRICSLyricsService, 5 forPlayerCommand.handleLyricsButton(), 1 forAudioPlayerManagerProvider(lyricsConfigured), 1 forCommandHandlerService(routing)ℹ️ Extra info
CommandHandlerServiceTest(0%→4.5%),PlayerCommandTest(6.7%→10.0%),AudioPlayerManagerProviderTest(83.3%→87.5%)