Adding support for Traps and Death Link - #3
Open
monologuemind wants to merge 4 commits into
Open
Conversation
…with traps), removed __post_init__ function from ItemData (after generating a game to get the values for all items) -- this tripped me up big time when adding in traps because it swapped the item_type to ITEM --, added in support for death link as I needed to port the death link function for the petrification trap
…me trap at the same time
…ields for LocationData
monologuemind
marked this pull request as ready for review
June 13, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DS2: Adding support for traps
Goes with this PR for the DS2 client
Traps, Death Link, Shared Traps (DS2 -> DS2 only), Random Carvings on (death or trap)