Skip to content

Adding support for Traps and Death Link - #3

Open
monologuemind wants to merge 4 commits into
WildBunnie:dark_souls_2from
monologuemind:mono/traps
Open

Adding support for Traps and Death Link#3
monologuemind wants to merge 4 commits into
WildBunnie:dark_souls_2from
monologuemind:mono/traps

Conversation

@monologuemind

@monologuemind monologuemind commented May 20, 2026

Copy link
Copy Markdown

DS2: Adding support for traps

Goes with this PR for the DS2 client

Traps, Death Link, Shared Traps (DS2 -> DS2 only), Random Carvings on (death or trap)

  • Adds a preset trap option (can be overridden manually, must know keys which is not great atm)
  • This also fixed a minor inconvenience with how the the ItemData class manipulated the item_type field. Remove the post_init function after writing all of the item_data to a file and pulling the item_type values into the source code (items.py)
  • Includes mapping functions for trap name and option name
  • currently tested playing through an async archipelago with all new settings enabled (max traps)
  • tested with 2 DS2 games running, sending traps via pickup and shop just fine -- local, and hosted (both vanilla and sotfs)
bleeding_trap

…with traps), removed __post_init__ function from ItemData (after generating a game to get the values for all items) -- this tripped me up big time when adding in traps because it swapped the item_type to ITEM --, added in support for death link as I needed to port the death link function for the petrification trap
@monologuemind monologuemind changed the title Adding support for Traps and Death Link Draft: Adding support for Traps and Death Link May 20, 2026
@monologuemind
monologuemind marked this pull request as ready for review June 13, 2026 23:35
@monologuemind monologuemind changed the title Draft: Adding support for Traps and Death Link Adding support for Traps and Death Link Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant