Adding support for in-game location area progress tracking - #4
Open
monologuemind wants to merge 3 commits into
Open
Adding support for in-game location area progress tracking#4monologuemind wants to merge 3 commits into
monologuemind wants to merge 3 commits into
Conversation
…egion tracking pickups
Open
4 tasks
…nto mono/items-per-region
…groups having an override region_id), fixed a bunch of type errors (caused some as a result and had to fix), added region_id to the location data sent to DS2 AP client, fixed some logic as a result of updating the key for the location group data
monologuemind
marked this pull request as ready for review
June 17, 2026 02:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds region_name to the locations to be used as tracking area progress
Relies on this PR to function.
Note: this does not have an updated total and percentage based on what is accessible by logic. If is purely the location counts that exist in each region. Adding in support for logical tracking would be a larger undertaking.
(kw_only=True))How was this tested?
Loaded up the AP and saw the base region name with 0 progress on locations, checked locations and then reviewed the fast travel menu to see the progress update. Then exited the game and reconnected to see that the progress is initialized properly when reconnecting and updating our region names with progress.
Tested on both sotfs and vanilla. Including a completed save on sotfs to check every single region. This is how I discovered that "Grand Cathedral" and "Dragon's Rest" do not have any AP items. This could be changed to take a select few that are currently grouped into "Frozen Eleum Loyce" and "Dragon's Sanctum" respectively.
Also tested with and without DLC enabled
If this makes graphical changes, please attach screenshots.