Skip to content

Adding support for in-game location area progress tracking - #4

Open
monologuemind wants to merge 3 commits into
WildBunnie:dark_souls_2from
monologuemind:mono/items-per-region
Open

Adding support for in-game location area progress tracking#4
monologuemind wants to merge 3 commits into
WildBunnie:dark_souls_2from
monologuemind:mono/items-per-region

Conversation

@monologuemind

@monologuemind monologuemind commented Jun 8, 2026

Copy link
Copy Markdown

Adds region_name to the locations to be used as tracking area progress
Relies on this PR to function.

Note: this does not have an updated total and percentage based on what is accessible by logic. If is purely the location counts that exist in each region. Adding in support for logical tracking would be a larger undertaking.

  • This also updated a bunch of type related errors I was seeing when editing files. This did require updating a large number of lines though (stricter with (kw_only=True))
  • Additional updates also had to be made to allow location groups to have a region_id in the key with the region name.

How was this tested?

  • Loaded up the AP and saw the base region name with 0 progress on locations, checked locations and then reviewed the fast travel menu to see the progress update. Then exited the game and reconnected to see that the progress is initialized properly when reconnecting and updating our region names with progress.

  • Tested on both sotfs and vanilla. Including a completed save on sotfs to check every single region. This is how I discovered that "Grand Cathedral" and "Dragon's Rest" do not have any AP items. This could be changed to take a select few that are currently grouped into "Frozen Eleum Loyce" and "Dragon's Sanctum" respectively.

    • We also have a fallback message if there aren't any AP items in a region to ensure we have a region title to display
  • Also tested with and without DLC enabled

If this makes graphical changes, please attach screenshots.

map_progress

…groups having an override region_id), fixed a bunch of type errors (caused some as a result and had to fix), added region_id to the location data sent to DS2 AP client, fixed some logic as a result of updating the key for the location group data
@monologuemind
monologuemind marked this pull request as ready for review June 17, 2026 02:22
@monologuemind monologuemind changed the title Draft: Adding support for in-game location area progress tracking Adding support for in-game location area progress tracking Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant