ci: exempt release-promotion PRs from pr-checks - #181
Open
Nic-dorman wants to merge 1 commit into
Open
Conversation
Promote PRs (a chore(release): title from an rc-* head branch) are mechanical version-bump PRs generated by the release process; they carry no Linear issue or template, so both required checks now self-pass on them. Both conditions are required, so an ordinary PR cannot opt out via its title alone. V2-1092 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-promotion PRs (e.g. #180) fail the
linear-linkandpr-templaterequired checks by design of the promote tooling — they are mechanical version-bump PRs with no Linear issue or template of their own. This exempts them from both checks incheck_pr.py: a PR qualifies only when its title starts withchore(release):and its head branch matchesrc-*, so an ordinary PR cannot opt out via its title alone. The checks pass (exit 0) rather than skip, because both are required status checks.These files are duplicated verbatim across the six crate repos; replication to the other five is follow-up scope tracked on the Linear issue.
Linear issue
Risk tier
Compatibility
Semver impact
Test evidence
python3 .github/scripts/test_check_pr.py— 21/21 cases pass, including 4 new: acceptance for both modes with the promote payload, plus rejections proving both conditions (title prefix, rc-* branch) are required. Spot-checked both modes with #180's exact title/branch/body: exit 0.New dependency
none
ADR
n/a
Mitigation / rollback
Revert the PR; both checks return to unconditional enforcement.
🤖 Generated with Claude Code