docs(build): list icon-32/96 in the AMO reproduction tree - #7
Merged
Conversation
BUILD.md tells an AMO reviewer the dist-firefox/ contents "match the uploaded package exactly", then listed 3 icons. The build produces 5 — icon-32.png and icon-96.png were added alongside the 0.1.1 manifest work and this listing never caught up. That's a problem in the one document whose entire purpose is proving the package is reproducible from source: a reviewer following it byte-for-byte finds two files that shouldn't be there. Verified the listing now matches the real build output exactly: 14 documented, 14 built, no drift either way. The rest of BUILD.md checks out — esbuild 0.25.12 / typescript 5.9.3 match package-lock.json, Node 24.15.0 and npm 11.12.1 match the toolchain, and package-lock.json is tracked so a reviewer's `npm ci` resolves. Refs V2-670. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUILD.mdtells an AMO reviewer thatdist-firefox/"match[es] the uploaded package exactly" — then lists 3 icons. The build produces 5:icon-32.pngandicon-96.pngcame in with the 0.1.1 manifest work and this listing never caught up.That matters because it's the one document whose entire purpose is proving the package is reproducible from source. A reviewer following it byte-for-byte finds two files that, per the doc, shouldn't exist.
Verified the listing now matches the build exactly — 14 documented, 14 built, no drift either way.
The rest of
BUILD.mdchecks out: esbuild0.25.12and typescript5.9.3matchpackage-lock.json, Node24.15.0/ npm11.12.1match the toolchain, andpackage-lock.jsonis tracked so a reviewer'snpm ciresolves.Found while prepping the 0.1.2 submission. Refs V2-670.
🤖 Generated with Claude Code