Repository navigation
Desktop files: Cascade-trash comment shortcuts when a comment is trashed - #1013
Open
CookieDarb wants to merge 1 commit into
Open
CookieDarb wants to merge 1 commit into
CookieDarb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #1012
Fixes the bug where comment shortcuts placed on the desktop wallpaper remain visible on the desktop instead of being moved to the Recycle Bin when the comment is trashed.
Why?
Desktop shortcuts for entities (posts, attachments, users) automatically cascade-trash their placements when the underlying entity is removed or moved to the trash. Comments had a registered desktop file type (
OpenStation_Comment_File), butcascade-cleanup.phplacked hooks for comments. As a result, trashing a comment left its desktop shortcut active on the wallpaper, and the shortcut was never routed to the Recycle Bin.How?
includes/desktop-files/cascade-cleanup.php:openstation_files_cascade_on_comment_trash( $comment_id )to soft-trash placement rows wherefile_type='comment'.trashed_commentanddeleted_commentactions to cascade comment trashing and permanent deletions to their desktop shortcuts.tests/phpunit/tests/desktopFilesCascadeCleanup.php:test_wp_trash_comment_triggers_cascade()to assert that callingwp_trash_comment()soft-trashes matching comment placements.test_delete_comment_triggers_cascade()to assert that callingwp_delete_comment()soft-trashes matching comment placements.Testing Instructions
Screencast
after-comment-cascase.mov
Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity
Model(s): Gemini
Used for: Adding tests and refining documentations.