Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ecgroupcom, @Crag-Monkey, @binaryfire, @Hotcooler, @solaceten, @diguinho2018. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
readme.txt also needs updating on couple of places regarding site-wide settings.
|
Thanks @todeveni - adjusted it accordingly :) |
|
So my uncertainty right now is how necessary this is. We've got U2F pared down, so the only providers we'd ship with are Backup Codes, TOTP, and Emailed Passwords? I don't think we want to enable disabling emailed passwords trivially as it's an important fallback. Backup codes and TOTP I'm also not sure we want to make easy to disable -- I'd personally prefer to have any disabling ui limited to a filter, with any additional providers easily disabled by disabling their plugin? Maybe I'm missing a use case here, @masteradhoc? |
What?
Fixes #249
Why?
Right now, site admins don’t have a UI to manage which Two-Factor providers are available on the site. Disabling providers requires custom code via filters. This PR provides a simple admin-facing settings page to enable/disable providers without requiring code changes.
How?
two-factor.php
class-two-factor-settings.php
class-two-factor-core.php
Adds enforcement filters:
Testing Instructions
Disabled providers no longer appear as available providers for users.
Existing users can’t enable newly-disabled providers.
Plugin Settings
User Settings
This PR also works with existing filter to disable providers. Those will not be shown on the settings page:
Screenshots or screencast
Changelog Entry