Add email verification before activation#788
Open
faisalahammad wants to merge 1 commit intoWordPress:masterfrom
Open
Add email verification before activation#788faisalahammad wants to merge 1 commit intoWordPress:masterfrom
faisalahammad wants to merge 1 commit intoWordPress:masterfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a verification step for the Email provider in the Two-Factor plugin.
Previously, users could enable Email 2FA without confirming ownership of the email address, which posed a risk of account lockout if the email was incorrect or inaccessible. This change aligns the Email provider's activation flow with the TOTP provider by requiring successful code verification before the provider can be enabled.
Changes
POST /two-factor/1.0/email: Handles sending verification codes and validating them.DELETE /two-factor/1.0/email: Handles resetting the verification status (if needed).Two_Factor_Email::is_available_for_user()now returnstrueonly if the user has verified their email (checked via_two_factor_email_verifieduser meta).pre_user_options_updatehook to prevent the Email provider from being enabled via the standard profile form save unless the user is verified.How to Test
New User (Fresh Setup)
Legacy User (Existing Setup)
Screenshot
Technical Details
Two_Factor_Emailregister_rest_routes()rest_setup_email()rest_delete_email()pre_user_options_update()user_options(): updated to render the verification UI.is_available_for_user(): added verification check (with legacy fallback).generate_and_email_token(): updated to accept an$actionargument ('login' vs 'verification_setup') to send context-appropriate emails.VERIFIED_META_KEY:_two_factor_email_verifiedChecklist
Fixes #778