Move class-two-factor-core.php login styles from inline to enqueued stylesheet#807
Move class-two-factor-core.php login styles from inline to enqueued stylesheet#807masteradhoc wants to merge 4 commits intoWordPress:masterfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
georgestephanis
left a comment
There was a problem hiding this comment.
Converting @to-do to @to-did? Nice.
I assume they aren't going to cause any conflicts with legacy usage of that file?
|
Should any of those CSS rules be tighter scoped? |
masteradhoc
left a comment
There was a problem hiding this comment.
@dd32 what do you think about the changes here? that would tighten the scope better.
| .input.authcode { | ||
| letter-spacing: 0.3em; | ||
| } | ||
|
|
||
| .input.authcode::placeholder { | ||
| opacity: 0.5; | ||
| } |
There was a problem hiding this comment.
| .input.authcode { | |
| letter-spacing: 0.3em; | |
| } | |
| .input.authcode::placeholder { | |
| opacity: 0.5; | |
| } | |
| #loginform .input.authcode { | |
| letter-spacing: 0.3em; | |
| } | |
| #loginform .input.authcode::placeholder { | |
| opacity: 0.5; | |
| } |
| .backup-methods-wrap { | ||
| margin-top: 16px; | ||
| padding: 0 24px; | ||
| } | ||
|
|
||
| .backup-methods-wrap a { | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .backup-methods-wrap ul { | ||
| list-style-position: inside; | ||
| } |
There was a problem hiding this comment.
| .backup-methods-wrap { | |
| margin-top: 16px; | |
| padding: 0 24px; | |
| } | |
| .backup-methods-wrap a { | |
| text-decoration: none; | |
| } | |
| .backup-methods-wrap ul { | |
| list-style-position: inside; | |
| } | |
| #login .backup-methods-wrap { | |
| margin-top: 16px; | |
| padding: 0 24px; | |
| } | |
| #login .backup-methods-wrap a { | |
| text-decoration: none; | |
| } | |
| #login .backup-methods-wrap ul { | |
| list-style-position: inside; | |
| } |
Step to achieve #63
What?
This PR removes the inline CSS block from the Two-Factor login screen and moves them to the user-edit.css stylesheet instead.
Why?
fix the outstanding TODO
How?
The login rendering flow now enqueues user-edit.css before outputting the login header, so the 2FA login UI receives the same styles via the stylesheet.
Testing Instructions
Screenshots or screencast
Changelog Entry