add fix for geometry validity#157
Merged
Merged
Conversation
tomkralidis
requested review from
alhelguera,
david-i-berry,
josusky and
maaikelimper
maaikelimper
approved these changes
Apr 27, 2026
Collaborator
|
Well, you asked me for review but did not wait. I do not have problem with the solution, but rather with the description. Commit message "This PR adds a test for geometry validity/integrity for erroneous geometry definitions (self-intersections, etc.)" is rather misleading. More appropriate would be "This PR adds a more detailed description for erroneous geometry definitions." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for geometry validity/integrity for erroneous geometry definitions (self-intersections, etc.)