-
Notifications
You must be signed in to change notification settings - Fork 12
Issue with input/test/measures #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ritikarawlani
wants to merge
4
commits into
main
Choose a base branch
from
testmeasures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # IMMZIND Measure Pointer Audit | ||
|
|
||
| **Date:** 2026-03-20 | ||
|
|
||
| ## Background | ||
|
|
||
| Each file in `input/tests/measures/` is a **pseudo-symlink** — a plain text file (not an OS-level symlink) containing a relative path. The tooling reads these files and treats them as pointers to a directory under `input/tests/plandefinition/` containing the actual test data. This pattern allows multiple measures to share the same test data. | ||
|
|
||
| ## Summary | ||
|
|
||
| | Status | Count | | ||
| |---|---| | ||
| | ✅ Working | 5 | | ||
| | ❌ Missing target (name mismatch) | 24 | | ||
| | ⛓️ Broken chain | 5 | | ||
| | ❌ Empty (no content) | 6 | | ||
| | **Total** | **40** | | ||
|
|
||
| Most missing-target cases are **name mismatches** — the plandefinition directory was likely renamed when the IG was restructured, but the pointer files were not updated. | ||
|
|
||
| ## Detail Table | ||
|
|
||
| | File | Status | Points To | Closest Existing Directory | | ||
| |---|---|---|---| | ||
| | IMMZIND01Logic | ✅ OK | `IMMZD2DTBCGLogic` | — | | ||
| | IMMZIND02Logic | ❌ EMPTY | *(nothing)* | — | | ||
| | IMMZIND03Logic | ⛓️ BROKEN CHAIN | `IMMZIND02Logic` (empty) | — | | ||
| | IMMZIND04Logic | ⛓️ BROKEN CHAIN | `IMMZIND02Logic` (empty) | — | | ||
| | IMMZIND05Logic | ❌ MISSING | `IMMZD2DTHepatitisBBirthLogic` | `IMMZD2DTHepatitisBBirthDoseLogic` | | ||
| | IMMZIND06Logic | ❌ MISSING | `IMMZD2DTPoliobOPVIPVLogic` | `IMMZD2DTPolioBOPVPlusIPVLogic` | | ||
| | IMMZIND07Logic | ❌ MISSING | `IMMZD2DTPoliobOPVIPVLogic` | `IMMZD2DTPolioBOPVPlusIPVLogic` | | ||
| | IMMZIND08Logic | ❌ MISSING | `IMMZD2DTPoliobOPVIPVLogic` | `IMMZD2DTPolioBOPVPlusIPVLogic` | | ||
| | IMMZIND09Logic | ❌ MISSING | `IMMZD2DTPoliobOPVIPVLogic` | `IMMZD2DTPolioBOPVPlusIPVLogic` | | ||
| | IMMZIND10Logic | ❌ MISSING | `IMMZD2DTPoliobOPVIPVLogic` | `IMMZD2DTPolioBOPVPlusIPVLogic` | | ||
| | IMMZIND11Logic | ❌ MISSING | `IMMZD2DTPolioIPVLogic` | `IMMZD2DTPolioIPVOnlyLogic` | | ||
| | IMMZIND12Logic | ❌ MISSING | `IMMZD2DTMeaslesOngoingTxLogic` | `IMMZD2DTMeaslesOngoingTransmissionLogic` | | ||
| | IMMZIND13Logic | ⛓️ BROKEN CHAIN | `IMMZIND12Logic` (missing) | — | | ||
| | IMMZIND14Logic | ❌ MISSING | `IMMZD2DTHPV2DoseLogic` | `IMMZD2DTHPV2DosesLogic` | | ||
| | IMMZIND15Logic | ❌ MISSING | `IMMZD2DTHPV2DoseLogic` | `IMMZD2DTHPV2DosesLogic` | | ||
| | IMMZIND16Logic | ❌ MISSING | `IMMZD2DTMeningococcalMenA1Logic` | `IMMZD2DTMeningococcalMenAConjugateVaccine1DoseLogic` | | ||
| | IMMZIND17Logic | ❌ MISSING | `IMMZD2DTPneumococcal3p0bLogic` | `IMMZD2DTPneumococcal3DosesLogic` | | ||
| | IMMZIND18Logic | ❌ MISSING | `IMMZD2DTPneumococcal3p0bLogic` | `IMMZD2DTPneumococcal3DosesLogic` | | ||
| | IMMZIND19Logic | ❌ MISSING | `IMMZD2DTPneumococcal3p0bLogic` | `IMMZD2DTPneumococcal3DosesLogic` | | ||
| | IMMZIND20Logic | ✅ OK | `IMMZD2DTRotavirusLogic` | — | | ||
| | IMMZIND21Logic | ✅ OK | `IMMZD2DTRotavirusLogic` | — | | ||
| | IMMZIND22Logic | ✅ OK | `IMMZD2DTRotavirusLogic` | — | | ||
| | IMMZIND23Logic | ❌ MISSING | `IMMZD2DTDTPOnTimeLogic` | `IMMZD2DTDTPOnTimeStartLogic` | | ||
| | IMMZIND24Logic | ❌ MISSING | `IMMZD2DTDTPOnTimeLogic` | `IMMZD2DTDTPOnTimeStartLogic` | | ||
| | IMMZIND25Logic | ❌ MISSING | `IMMZD2DTDTPOnTimeLogic` | `IMMZD2DTDTPOnTimeStartLogic` | | ||
| | IMMZIND26Logic | ❌ MISSING | `IMMZD2DTYellowfeverLogic` | `IMMZD2DTYellowfeverYellowFeverLogic` | | ||
| | IMMZIND27Logic | ❌ MISSING | `IMMZD2DTJEIVLogic` | `IMMZD2DTJEInactivatedVeroCellDerivedVaccineLogic` (?) | | ||
| | IMMZIND28Logic | ✅ OK | `IMMZD2DTTyphoidTCVLogic` | — | | ||
| | IMMZIND29Logic | ❌ MISSING | `IMMZD2DTSeasonalinfluenza2DoseLogic` | `IMMZD2DTSeasonalinfluenzaSeasonalInfluenzaLogic` | | ||
| | IMMZIND30Logic | ❌ EMPTY | *(nothing)* | — | | ||
| | IMMZIND31Logic | ❌ MISSING | `IMMZD2DTMalaria4DoseLogic` | `IMMZD2DTMalariaLogic` | | ||
| | IMMZIND32Logic | ❌ MISSING | `IMMZD2DTMalaria4DoseLogic` | `IMMZD2DTMalariaLogic` | | ||
| | IMMZIND33Logic | ❌ MISSING | `IMMZD2DTMalaria4DoseLogic` | `IMMZD2DTMalariaLogic` | | ||
| | IMMZIND34Logic | ❌ MISSING | `IMMZD2DTMalaria4DoseLogic` | `IMMZD2DTMalariaLogic` | | ||
| | IMMZIND35Logic | ❌ EMPTY | *(nothing)* | — | | ||
| | IMMZIND36Logic | ❌ EMPTY | *(nothing)* | — | | ||
| | IMMZIND37Logic | ⛓️ BROKEN CHAIN | `IMMZIND13Logic` → `IMMZIND12Logic` (missing) | — | | ||
| | IMMZIND38Logic | ⛓️ BROKEN CHAIN | `IMMZIND34Logic` (missing) | — | | ||
| | IMMZIND39Logic | ⛓️ BROKEN CHAIN | `IMMZIND34Logic` (missing) | — | | ||
| | IMMZIND44Logic | ❌ EMPTY | *(nothing)* | — | | ||
| | IMMZIND45Logic | ❌ EMPTY | *(nothing)* | — | | ||
|
|
||
| ## Grouped by Issue | ||
|
|
||
| ### Empty files (no pointer content) | ||
| - IMMZIND02Logic, IMMZIND30Logic, IMMZIND35Logic, IMMZIND36Logic, IMMZIND44Logic, IMMZIND45Logic | ||
|
|
||
| ### Broken chains (point to another IMMZIND that is itself broken) | ||
| - IMMZIND03Logic, IMMZIND04Logic → `IMMZIND02Logic` (empty) | ||
| - IMMZIND13Logic → `IMMZIND12Logic` (missing target) | ||
| - IMMZIND37Logic → `IMMZIND13Logic` → `IMMZIND12Logic` (missing target) | ||
| - IMMZIND38Logic, IMMZIND39Logic → `IMMZIND34Logic` (missing target) | ||
|
|
||
| ### Missing targets grouped by target name | ||
|
|
||
| | Target (in pointer file) | Likely intended directory | Affected IMMZIND files | | ||
| |---|---|---| | ||
| | `IMMZD2DTHepatitisBBirthLogic` | `IMMZD2DTHepatitisBBirthDoseLogic` | IND05 | | ||
| | `IMMZD2DTPoliobOPVIPVLogic` | `IMMZD2DTPolioBOPVPlusIPVLogic` | IND06–10 | | ||
| | `IMMZD2DTPolioIPVLogic` | `IMMZD2DTPolioIPVOnlyLogic` | IND11 | | ||
| | `IMMZD2DTMeaslesOngoingTxLogic` | `IMMZD2DTMeaslesOngoingTransmissionLogic` | IND12 (+ IND13, IND37 via chain) | | ||
| | `IMMZD2DTHPV2DoseLogic` | `IMMZD2DTHPV2DosesLogic` | IND14–15 | | ||
| | `IMMZD2DTMeningococcalMenA1Logic` | `IMMZD2DTMeningococcalMenAConjugateVaccine1DoseLogic` | IND16 | | ||
| | `IMMZD2DTPneumococcal3p0bLogic` | `IMMZD2DTPneumococcal3DosesLogic` | IND17–19 | | ||
| | `IMMZD2DTDTPOnTimeLogic` | `IMMZD2DTDTPOnTimeStartLogic` | IND23–25 | | ||
| | `IMMZD2DTYellowfeverLogic` | `IMMZD2DTYellowfeverYellowFeverLogic` | IND26 | | ||
| | `IMMZD2DTJEIVLogic` | `IMMZD2DTJEInactivatedVeroCellDerivedVaccineLogic` (?) | IND27 | | ||
| | `IMMZD2DTSeasonalinfluenza2DoseLogic` | `IMMZD2DTSeasonalinfluenzaSeasonalInfluenzaLogic` | IND29 | | ||
| | `IMMZD2DTMalaria4DoseLogic` | `IMMZD2DTMalariaLogic` | IND31–34 (+ IND38–39 via chain) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "package-id" : "smart.who.int.immunizations", | ||
| "title" : "Immunizations", | ||
| "category" : "base", | ||
| "introduction" : "SMART Immunization Implementation Guide", | ||
| "version" : "1.0.0", | ||
| "desc" : "1.0.0 release", | ||
| "mode" : "milestone", | ||
| "path" : "http://smart.who.int/immunizations/v1.0.0", | ||
| "ci-build": "http://worldhealthorganization.github.io/smart-immunizations", | ||
| "first": true, | ||
| "status" : "release", | ||
| "sequence" : "Releases" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litlfred @lukeaduncan @costateixeira
Attached a report here from CLaude about the missing links in the input/tests/measures folder