Repository navigation
Refactor the hugo count into more readable form - #518
Merged
offbyone merged 1 commit intoOct 18, 2026
Merged
Conversation
Test some edge case scenarios in hugo counting. All of these are actual issues, albeit only in rare instances: - when no award wins the IRV, don't have a runoff (this can't change the result, but is weird.) - 3.12.1: if all remaining finalists are tied, then there should be no tiebreak (which seems to contradict #429); this can affect a rare circumstance where the last tie for elimination tie-breaks out a joint winner - all tied joint winners when returned should omit No Award -- this is a reporting bug, not critical. This PR adds extended, currently failing tests for these edge cases
offbyone
added
the
patch
offbyone
deleted the
refactor-the-hugo-count-into-more-readable-form/wnynmnkkpouo
branch
October 18, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warren spotted some edge case counting bugs in the Hugo algorithm
this change intros some expected failing tests around those, as well as some new ones that pass, and is focused on refactoring the hugo counter so it's easier to reason about.