Feat/additional info apps by CAmi307 · Pull Request #4 · Wyliodrin/async-debugger

CAmi307 · 2025-06-30T09:55:08Z

No description provided.

…me timestamp

…me info

…in/async-debugger into feat/additional-info-apps

…r interaction - chart.js, soon to be replaced

valexandru

Inca nu am terminat review-ul pe toate componentele, dar ca si intrebari/sugestii generale:

Avem cumva vreun mod de management de log-uri? Adica pe baza unui flag sa afisam doar error-urile de exemplu?
Ar fi super daca pentru macar unul din exemplele pe care le avem daca putem face un screen recording de cum se foloseste tool-ul pe acel exemplu. Si il putem include ca un gif de exemplu in README

valexandru · 2025-09-18T09:08:09Z

In fisierul asta as mai vrea sa mai vad urmatoarele sectiuni si modificari:

Requirements - care sa specifice pe ce sisteme de operare functioneaza, daca trebuie sa ai ceva anume instalat si ce anume

In momentul in care vom avea release-uri pe repo-ul asta, vom avea direct applicatiile generate iar utilizatorii vor putea direct descarca si instala release-urile respective. Putem face un release cu un tag 0.1.0 sau ceva de genul asta pe branch-ul asta si sa scriem aici in readme cum se instaleaza/foloseste

De asemenea, as vrea sa mai vad niste screenshot-uri reprezentative cu aplicatia ca sa fie ceva mai de impact pentru utilizator

De asemenea, vreau sa mai avem un mic fisier gen Architecture.md care sa descrie componentele aplicatiei si cum comunica intre ele, dar si ierarhia repository-ului la modul:

--- src-tauri |------ commands -> comenzile apelabile de catre componenta de front-end. + descriere sumara de care sunt ele

valexandru · 2025-09-18T10:00:45Z

Plus daca poti sa rezolvi conflictele care sunt fata de branch-ul main

valexandru · 2025-09-23T07:43:19Z

+use std::sync::Arc;
+use tokio::sync::{Barrier, RwLock};
+use tokio::time::{Duration, Instant, sleep};
+


Short docs description here at the beginning of this file for what it does and its purpose.

valexandru · 2025-09-23T07:46:31Z

Let's choose a better format to display the time here in the "ReceivedAt" column. Something similar to what you did in the other screens

valexandru · 2025-09-23T07:47:06Z

Yup, the reason why it loads so slowly is the size of the gif. Let's compress it a bit more to improve the loading performance

valexandru · 2025-09-23T07:48:19Z

Let's change the "Target" column name into something more suggestive

valexandru · 2025-09-23T07:49:06Z

Besides application names, let's also put actual names at "Name" instead of the "No Name" value

valexandru · 2025-09-23T08:13:04Z

+ # Architecture
+ ```
+                                                                                                                                                            ┌── common.rs/get_pid_hosting_at ────────┐
+                                                                                                                           ┌── domain/application.rs/new ─> │                                        │


Change this into a draw.io with a bit more explanations about what does components do.

valexandru · 2025-09-23T09:42:18Z

+                debug!("Enabling app {}", app.title());
+                self.state.enable_app(*app.id(), connection).await;
+            } else {
+                // TODO


We need to replace this with at least logging on error.

valexandru · 2025-09-23T09:43:12Z

        self.state.get_current_applications_list().await
    }

    pub async fn delete_connection(&self, uuid: Uuid) {
        self.connection_manager.disconnect_app(uuid).await;
-        self.state.delete_app(uuid).await
+        //     self.state.delete_app(uuid).await


Suggested change

// self.state.delete_app(uuid).await

valexandru · 2025-09-23T09:52:24Z

+            }
+            // Update app connection status
+            if app.state() == ApplicationState::Disabled {
+                // If app is disabled we dont save anything


Suggested change

// If app is disabled we dont save anything

// If app is disabled, we don't save anything

valexandru · 2025-09-23T09:53:19Z

+    ) {
+        // debug for missed resources_updates
+        if resources_update.dropped_events > 0 {
+            println!(


let's use debug, info and error everywhere instead of println!

valexandru · 2025-09-23T09:59:35Z

+        // Use netstat to list all TCP/UDP connections with PIDs.
+        let output = Command::new("netstat").args(["-ano"]).output().ok()?;
+        // This needs to be lossy, because the netstat output sometimes contains non UTF-8 characters
+        let stdout = String::from_utf8_lossy(&output.stdout);


Add comment that this is needed for running on windows

valexandru · 2025-09-23T10:16:25Z

We need to restructure all the Vue component files. Here is an example of the component:

// The template that contains the html code comes first <template> <div class="counter"> <h2>Count: {{ count }}</h2> <p>Double: {{ doubleCount }}</p> <button @click="increment">Increment</button> </div> </template> // Then, we have the typescript/javascript code <script> // Exporting the component export default { name: 'Counter', // parameters of the components -> you can think of them as the global variables data() { return { count: 0 } }, // values that are computed by a function computed: { doubleCount() { return this.count * 2 } }, // these are the more complex functions that you use in the code, for example actions on buttons methods: { increment() { this.count++ } } } </script> // Finally, if there is needed, local styles used in the file <style scoped> .counter { padding: 1em; border-radius: 4px; background: #f5f5f5; } button { margin-top: 10px; } </style>

valexandru · 2025-09-23T10:16:57Z

+  {title: "Location", key: "location", align: "center"},
+]);
+
+const appList = computed(() => {


For example, this computed parameter should be in the computed parameter of the Vue component (see the main file).

valexandru · 2025-09-23T10:17:22Z

+      </v-data-table>
+    </v-card-text>
+  </v-card>
+</template>


Suggested change

</template>

</template>

This applies to all files

valexandru · 2025-09-23T10:18:47Z

+                    appToEdit.id = uuid as string;
+                }
+            ).catch(
+                (e) => console.log("Failed to edit application due to " + e)


For consistency, when you have an error, use console.err()

valexandru · 2025-09-23T10:18:55Z

+            ).catch(
+                (e) => console.log("Failed to edit application due to " + e)
+            );
+            //appToEdit.connection_status = "Connected";


Suggested change

//appToEdit.connection_status = "Connected";

valexandru · 2025-09-23T10:25:42Z

If this is not needed, let's just delete it

valexandru · 2025-09-23T10:29:39Z

We also need workflows for checking rust and typescript code. Maybe move them from the code in the Andrei's PR

DTeodor-Alexaandru

Overall review:

Each ramification should be logged, otherwise the app debugging will be hard
Each operation that may fail should be error handled and logged..
In many places Option is used instead of Result and there is no log
In frontend all the errors should be handled or at least displayed, there shouldn t be any user interaction with no outcome to the user
Let's replace everywhere println! with logger
The thread panic should be handled properly, if a thread panics and other work fine, what will be the outcome? The app is fine to continue or it should be restarted?

DTeodor-Alexaandru · 2025-09-23T10:03:15Z

I would add in prerequisites section all the prerequisites:)))
Eg deno, webkit2gtk-4.1, libsoup-3.0 etc... for the final version i would start with a fresh os and note all the dependencies

DTeodor-Alexaandru · 2025-09-23T10:05:20Z

+  cargo run --example <example_name>
+```
+
+- `0s1s` spawns three asynchronous tasks:


bullet point listing is a bit unclear, I would enumerate

DTeodor-Alexaandru · 2025-09-23T10:13:10Z

+            if zero_tx.send(chunk).await.is_err() {
+                break;
+            }
+            println!("Sent 1 chunk of 0s");


I would use logger, instead of println!

DTeodor-Alexaandru · 2025-09-23T10:16:16Z

-use crate::error::Error;
-use crate::state_manager::StateManager;
+#[derive(Serialize, Deserialize)]
+pub struct ExportEntry {


Let's have a separate structs dir and splitted into domains

Also, doc for all the structs

DTeodor-Alexaandru · 2025-09-23T10:19:25Z

+    let conn: Connection = state_manager
+        .connection_manager
+        .connect_app(*app.id(), app.url().clone(), app.pid())
+        .await?;


The error is handled properly in the frontend? Or just logged?

I would also log the error before throwing it

DTeodor-Alexaandru · 2025-09-23T11:36:41Z

+        if let Some(app) = apps.get_mut(&app_id) {
+            app.writeable().set_pid(new_pid);
+        }
+        // drop guard


Suggested change

// drop guard

DTeodor-Alexaandru · 2025-09-23T11:37:55Z

+    ///    and update each poll’s `task_name` and `task_color`.
+    /// 3. If there is an entry in the task‐operations store matching
+    ///    the same key, update its `task_name` and `task_color` as well.
+    pub async fn edit_state_task(


error handling, if the task id doesn't exist

DTeodor-Alexaandru · 2025-09-23T11:38:58Z

+    ///    – Otherwise, append a new `CPUOverview` entry (with `started_at` and optional `stopped_at`).  
+    ///    – If no `TaskOp` record exists, create one from scratch using any known
+    ///      task metadata (name/color) and the new CPU overview.  
+    pub async fn handle_async_op_update(&self, app_id: Uuid, async_op_update: AsyncOpUpdate) {


same idea, error handling

DTeodor-Alexaandru · 2025-09-23T11:42:25Z

+                    appToEdit.id = uuid as string;
+                }
+            ).catch(
+                (e) => console.log("Failed to edit application due to " + e)


the error should be handled or at least displayed

* wip * fix lint and refactor sysinfo * fix rust code * remove cpu * fix navitems * fix sidebar * update workflow --------- Co-authored-by: Cristiana Precup <cristianaprecup65@gmail.com>

CAmi307 · 2025-10-02T08:55:05Z

As face un modul warning, in mod.rs sa pastram trait-ul Warning, iar in sub-module separate sa facem cate un fisier pentru fieacare tip de warning

* move computation from tauri-commands to backend * remove unused function * fix edit task method * remove any

CAmi307 added 3 commits March 3, 2025 11:58

feat: get pid for application

f064cca

get process info for app

1368c4e

change hashmaps to lists and fix data update bug

fc35b15

CAmi307 force-pushed the feat/additional-info-apps branch 2 times, most recently from c33fb8a to e582461 Compare July 1, 2025 09:25

wip

b98533b

CAmi307 force-pushed the feat/additional-info-apps branch from e582461 to b98533b Compare July 1, 2025 09:38

cristian-paris and others added 23 commits July 2, 2025 12:44

rebase

c88fe64

Replace the UUID references to a friendlier app name format

10ea659

Replace the UUID references to a friendlier app name format

fdbd4e2

bug fixes

02cca8e

get PID for windows

20215ad

added disable functionality and improved start time format

c132c74

fixed linux conditional compiling bug + added seconds in the start ti…

6748239

…me timestamp

add feedback-ui for applications

a999dd4

Use conn-status from backend Application struct

d782fe0

[WIP] Keep a list of stopped tasks

0e2f20c

[WIP] Show dropped tasks as stopped

2f6dbf3

fixed key format for tasks_guard

8ac42af

fixed key format for tasks_guard

90121d3

frontend accomodations for the future feature of showing more task ti…

bb7cd2f

…me info

removed unused imports

4f29ff6

removed unused imports

7a5667b

get more tasks info on handle_task_update

4a3d7a1

Merge branch 'feat/additional-info-apps' of http://github.com/Wyliodr…

191936b

…in/async-debugger into feat/additional-info-apps

sanitised state output

19d0fb4

Improve display of subsecond time units (ms, μs, ns)

c54da30

Merge branch 'feat/additional-info-apps' of http://github.com/Wyliodr…

9271c70

…in/async-debugger into feat/additional-info-apps

fix negative idle time + pause feat for tasks

d40b29a

error handling + error feedback for UI

9ab7115

U-alb added 5 commits August 29, 2025 15:56

fmt

dfa82a3

Switched to local timestamps

595910e

Added import/export of app instances

a654903

Updated documentation on the export instance function

cdec4af

CPU Overview: added gap compression, user preferences and better hove…

e1fcebc

…r interaction - chart.js, soon to be replaced

valexandru reviewed Sep 18, 2025

View reviewed changes

U-alb added 7 commits September 18, 2025 17:51

Solved some of the PR comments

e3e8cda

removed .lock file

8b0cdeb

Merge branch 'main' into feat/additional-info-apps

6b840b7

Added architecture page

a9f5f7e

Moved duration formatting logic to the frontend

1e8d601

Added screenshots in the README

3420f18

Added how-to GIF in the README

76ccb66

valexandru reviewed Sep 23, 2025

View reviewed changes

DTeodor-Alexaandru reviewed Sep 23, 2025

View reviewed changes

U-alb and others added 3 commits September 26, 2025 14:43

Migrated chart logic to the updated timestamp structs

99000a1

Migrated chart logic to the updated timestamp structs

4ec6a47

Chore/front end rework (#7)

7ccbd64

* wip * fix lint and refactor sysinfo * fix rust code * remove cpu * fix navitems * fix sidebar * update workflow --------- Co-authored-by: Cristiana Precup <cristianaprecup65@gmail.com>

github-actions Bot added Workflow UI Backend labels Oct 1, 2025

CAmi307 commented Oct 2, 2025

View reviewed changes

Comment thread src-tauri/src/utils/common.rs Outdated

CAmi307 commented Oct 2, 2025

View reviewed changes

DTeodor-Alexaandru and others added 3 commits October 2, 2025 12:08

architecture rework (#8)

dea0244

Refactor features (#9)

4cdb0ec

* move computation from tauri-commands to backend * remove unused function * fix edit task method * remove any

Add error handling (#10)

1e7e326

	// If app is disabled we dont save anything
	// If app is disabled, we don't save anything

Uh oh!

Conversation

CAmi307 commented Jun 30, 2025

Uh oh!

valexandru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valexandru commented Sep 18, 2025

Uh oh!

valexandru Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valexandru Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valexandru Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valexandru Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valexandru Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valexandru commented Sep 23, 2025

Uh oh!

DTeodor-Alexaandru left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valexandru Sep 23, 2025 •

edited

Loading

valexandru Sep 23, 2025 •

edited

Loading

valexandru Sep 23, 2025 •

edited

Loading

valexandru Sep 23, 2025 •

edited

Loading

valexandru Sep 23, 2025 •

edited

Loading