Few fixes related to libstrophe - #4
Open
pasis wants to merge 5 commits into
Open
Conversation
libstrophe returns attribute as a pointer to internal data. Hence, it must not be changed. Define respective variables as const to reduce the chance of mistake. Also, libstrophe-0.9 will change const char* for non allocated strings.
Results of xmpp_stanza_get_text() and xmpp_stanza_to_text() must be freed by xmpp_free().
Let libstrophe to choose proper port number. First, the library tries to resolve xmpp record. If it fails the default port is chosen in accordance with SSL configuration. Therefore, default port can be 5223 in case of legasy SSL option.
libstrophe's connection may disconnect. This can happen on network errors, when device wakes up after sleep, etc. Don't call xmpp_connect() recursively, because stack will be consumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested these changes, because I don't have required environment.