Skip to content

Error handling of Unexpected termination of child#46

Open
woytam wants to merge 4 commits into
WyriHaximus:masterfrom
woytam:patch-1
Open

Error handling of Unexpected termination of child#46
woytam wants to merge 4 commits into
WyriHaximus:masterfrom
woytam:patch-1

Conversation

@woytam

@woytam woytam commented Oct 29, 2019

Copy link
Copy Markdown

Handle Unexpected child termination (when child process is killed for example) and keep number of processes upper Options::MIN_SIZE.
todo: No tests committed.

Handle Unexpected child termination and keep number of processes upper Options::MIN_SIZE
Comment thread src/Manager/Flexible.php Outdated
Comment thread src/Manager/Flexible.php Outdated

@WyriHaximus WyriHaximus left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 👍 ! Looks mostly good, one parser error tho. Also would love to have tests for this, glad to help out with that is you get stuck

Comment thread src/Manager/Flexible.php
Comment thread src/Manager/Flexible.php Outdated
Parse error fixed

Co-Authored-By: Cees-Jan Kiewiet <ceesjank@gmail.com>
@woytam

woytam commented Dec 13, 2019

Copy link
Copy Markdown
Author

I'm sorry, but tests are too complicated for me.

@WyriHaximus

Copy link
Copy Markdown
Owner

No problem I'll have a look at it soon

@boring-cyborg boring-cyborg Bot added PHP 🐘 Hypertext Pre Processor Source 🔮 labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 🐘 Hypertext Pre Processor Source 🔮

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants