Fix _TOTAL_BAR regex pattern matching - #224
Merged
Wyze3306 merged 2 commits intoAug 24, 2026
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The launcher briefly prints an invalid download percentage before
settling into a normal 0-100% bar, then launches fine (#223).
Root cause
_TOTAL_BARmatched on the prefix of a progress bar's label(
^(initializing|downloading)), not the whole label. The realaggregate bar's label is exactly "Downloading", but a per-file or
per-segment bar can be captioned "Downloading " — same prefix.
That segment's own tiny, near-complete total briefly gets read as the
whole package's total, so the percentage is computed against the
wrong denominator for one frame, until the next line (the real
aggregate bar) corrects it.
The Fix:
Anchor
_TOTAL_BARto the full label instead of a prefix match:Testing
pytest tests/test_xodus.py— 83 passedtest_a_segment_bar_labelled_downloading_is_not_the_total_bar,which feeds
_consumea "Downloading segment_0000.msixvc" line andasserts it's ignored, then confirms the real aggregate bar still
drives progress correctly
Closes #223