fix(auth): reuse a fresh Xbox Live token chain at PLAY instead of refetching it - #254
Open
xRookieFight wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_warm_xbox_preauthhad just minted the same tokens with hours of validity left — about 10s of every launch's wait spent redoing work that was already done.xbl_preauthnow reuses the cached online payload when it still clears a 30-minute margin, and only re-runs the chain once that margin is gone (or the cache is missing/stale), so a warm background sign-in actually gets used at PLAY.Test plan
python -m pytest tests/test_auth_settings.py tests/test_auth_errors.py -q— added two new tests: a fresh cache skips the network entirely, and a cache below the reuse margin still drives a real refresh.python -m pytest tests/ -q— full suite passes (one pre-existing, unrelated failure on this machine from a missingrpmCLI, reproduced onmain).