Conversation
Follow-up to XBuilderLAB#69 (closes the remaining part of XBuilderLAB#68). Four skills still carry an unquoted `argument-hint:` value whose text starts with `<…>` and contains `[… : …]`. The `: ` inside that part reads as a nested mapping, so strict YAML parsers (js-yaml / the `yaml` package used by pi) fail on the frontmatter and drop the skill, while lenient parsers (PyYAML) accept it — which is why XBuilderLAB#69 missed these. - skills/cheat-learn-from/SKILL.md - skills/cheat-predict/SKILL.md - skills/cheat-publish/SKILL.md - skills/cheat-retro/SKILL.md Same mechanical fix as XBuilderLAB#69: wrap the value in double quotes so it parses as a plain string. No value contains `"` or `\`, so wrapping is safe, and the parsed string is unchanged. Verification: pi 0.85.1's skill loader (bundled `yaml` parser) over the skill directory returns no skill and a "Nested mappings are not allowed in compact mappings" warning before the change, and loads the skill with zero diagnostics after it: before -> skills: [] diagnostics: ['Nested mappings …'] after -> skills: ['cheat-predict'] diagnostics: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69, closes the remaining part of #68.
Summary
Four skills still carry an unquoted
argument-hint:value whose text starts with<…>and contains[… : …]:skills/cheat-learn-from/SKILL.mdskills/cheat-predict/SKILL.mdskills/cheat-publish/SKILL.mdskills/cheat-retro/SKILL.mdSame mechanical fix as #69: wrap the value in double quotes so every YAML parser reads it as a plain string.
Why #69 missed these four
#69 was about values that start with
[, which YAML parses as a flow sequence. These four start with<…>, so they look like plain scalars — but the:inside the bracketed part (way: a,mode: v1,platform: …,window: 3) reads as a nested mapping, which is a hard parse error rather than a shape mismatch. Lenient parsers (PyYAMLsafe_load) accept it, so a lint pass can miss it; strict parsers reject the whole frontmatter.Impact
Strict loaders drop the skill entirely. With pi 0.85.1's skill loader, which uses the
yamlpackage:Verification
skills/*/SKILL.mdplus the rootSKILL.mdparses with theyamlpackage; each changed file returnsargument-hintas astrloadSkillsFromDirfrom pi 0.85.1 loads the changed skills with zero diagnostics (before: skill dropped + warning)"or\, so plain double-quote wrapping is safe and the parsed string is unchangedThe other unquoted hints (
cheat-bump,cheat-score,cheat-score-blind,cheat-shoot) contain no:and parse as plain scalars, so they are left untouched.Relation to #73
Same scope and same one-line change as #73, filed from a fork rebased on current
main(d2d818f). Either one can be merged; happy to close this one if #73 lands first.