Repository navigation
Web installer: usable, and in the dashboard's colors - #105
Merged
Merged
Conversation
- Our "Flash a new board" dialog is modal, so the page outside it was
inert, ESP Web Tools' own dialog included: the install couldn't go on,
and the port stayed open ("Failed to open serial port" next time). It
now closes when the install starts.
- ESP Web Tools' dialogs (Material 3 inside) get the dashboard's colors,
font and shapes, dark mode included: their defaults sit on :host, which
a rule naming the element overrides.
Tested with a Lolin S3 (ESP32-S3) and an ESP8266 installed from Brave.
Fixes #104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
showModal), which made everything outside it inert — including the dialog ESP Web Tools opens once the port is picked. The install couldn't proceed and the port stayed open, so the next try failed with Failed to open serial port. Our dialog now closes when the install starts.ewt-install-dialog,ewt-no-port-picked-dialog, Material 3) now use the dashboard's accent, surfaces, text, error color, system font and corner radii, light and dark. Their defaults are set on:host, so the tokens are set on the elements themselves as well as:root.Tested by the user on real boards: a Lolin S3 (ESP32-S3) and an ESP8266 installed from Brave, then joined Wi-Fi via Improv (S3). Light/dark checked in Chromium.
🤖 Generated with Claude Code