Repository navigation
Tighten native/Kotlin command validation for exact keyword:value syntax - #40
Merged
Merged
Conversation
Co-authored-by: XRDOGE-XRPL <166251416+XRDOGE-XRPL@users.noreply.github.com>
XRDOGE-XRPL
approved these changes
Sep 18, 2026
XRDOGE-XRPL
marked this pull request as ready for review
September 18, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command validation path allowed malformed
keyword :valueforms to pass through as valid commands, which could confuse the native state machine and break the expected transport contract. The parser was accepting whitespace before the separator even when the normalized form still looked valid, so the raw command syntax needed to be enforced exactly.Summary
keyword:valuesyntax for native commands, including the transport command contract.:.What changed
transport :udpis invalid even if normalized text looks acceptable).ClientStateparser, the same raw-prefix check is enforced before accepting a command value.Example
Impact
transport:<value>,connect:<server>,player:<name>, etc. must use exact keyword syntax without whitespace before the separator.