Repository navigation
Reject unsupported native commands instead of silently accepting them - #41
Merged
Merged
Conversation
Co-authored-by: XRDOGE-XRPL <166251416+XRDOGE-XRPL@users.noreply.github.com>
XRDOGE-XRPL
approved these changes
Sep 18, 2026
XRDOGE-XRPL
marked this pull request as ready for review
September 18, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was caused by the native command dispatcher accepting any unrecognized command through a generic fallback path, which bypassed the JVM-side validation contract. That meant malformed or unsupported commands could be treated as valid and stored as the last command, creating inconsistent runtime state and hiding invalid input.
Summary
What changed
ClientState::dispatchCommand()now returnsfalsefor unrecognized commands, preserving the intended fail-fast behavior.Example