Add WithOperationNameSetter to allow control of the operation name sent to metrics #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to otel metrics
XSAM
reviewed
Jan 22, 2026
| type InstrumentErrorAttributesGetter func(err error) []attribute.KeyValue | ||
|
|
||
| // OperationNameSetter allows controlling the operation name provided to metric instruments. | ||
| type OperationNameSetter func(ctx context.Context, method Method, query string) string |
Owner
There was a problem hiding this comment.
Could we use OperationNameFormatter to align with the naming of SpanNameFormatter?
I also think this method can be used for spans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating this from a branch so I can update the module path on my fork.
This allows folks to customise the operation name attribute sent on metrics.
The signature is the same as the SpanNameFormatter, so the same function could be used for both, which is probably generally desirable.
Potentially so desirable, that we could avoid the second config option and always do this, but this has better BC.