Repository navigation
Fix Windows openXYOS install extract and native folder picker for source download - #26
Merged
Merged
Conversation
…e download. NSIS no longer calls PowerShell to unzip into Program Files (spaces broke quoting and left $INSTDIR\openxyos as README-only). Setup now expands the prebuilt zip with tar.exe into both openxyos and openxyos-runtime, and aborts if node.exe or dist/index.html is missing. First launch copies the complete tree, including the staged runtime, to LocalAppData. Organization "download latest openXYOS source" opens the same Wails folder picker as project workdirs instead of a typed path or window.prompt. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
cursor
Bot
force-pushed
the
cursor/fix-openxyos-nsis-extract-2aa0
branch
from
September 16, 2026 05:12
ce8d2ad to
4400ecd
Compare
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P0: after installing to
D:\Program Files\FreeOS,$INSTDIR\openxyoswas left README-only while the zip landed beside it asopenxyos-runtime\. NSIS called PowerShell to unzip with''$INSTDIR''quoting; spaces inProgram Filessplit the command, extract failed silently, and first launch copied the stub.Rebased onto latest
main(includes #23 mutual-growth). Conflict inOrganization/index.tsxresolved by keeping both #23 produce-colleague state and the native folder picker.This PR:
.cmdwith expanded paths and use Windowstar.exeto unpack the CI-prebuiltopenxyos-runtime.zipinto both$INSTDIR\openxyosand$INSTDIR\openxyos-runtime. Log the exit code. Abort setup (error 67) ifnode\node.exeordist\index.htmlis missing.makensisfails at compile time if the zip was not staged.$INSTDIR\openxyos-runtime, so a leftover staged tree is copied in full to%LOCALAPPDATA%\FreeOS\openxyos. README-only trees are never treated as ready. Sidecar still auto-starts when the tree is healthy (http://127.0.0.1:3780/api/health/livez).layout_ready/verify_runtime_zipreject README-only zips; NSIS tests requiretar.exe, quoted$INSTDIR, andAborton missing files.window.prompt/ typed-path-only on desktop.Does not require
npm buildon the user’s PC. No merge / no Release.Target branch
main(hotfix-style P0 from latest main)Type of change
Test plan
1dd99b1f(Harden Organization mutual growth between FreeOS and openXYOS #23); Organization conflict resolveduv run pytest tests/unit/desktop/test_nsis_uninstall.py tests/unit/desktop/test_stage_openxyos_runtime.py tests/unit/test_sidecar_launch.py -q— 24 passedvitestpickSourceDest4400ecd8: Python 3.12, Windows Python 3.12, Desktop Package windows-amd64 / windows-arm64 (Release attach skipped)Checklist
CHANGELOG.mddesktop/README.mdupdated