Repository navigation
Fix NSIS installer abort when openXYOS livez is slow - #33
Merged
Merged
Conversation
cmd.exe never saw :liveNodeOk because the generated extract script wrote liveNodeOk: (invalid goto target), so extract exited 1. Probe then aborted the whole installer when livez was slow. Keep Abort only when node/dist are missing; warn and continue when files and autostart are in place. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
Stamp the live workdir after layout and autostart succeed, so a slow sidecar cannot leave Organization without the install-ready marker. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
XYAIStudio
marked this pull request as ready for review
September 16, 2026 13:00
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Setup of v0.0.1 aborted around 40% after extracting openXYOS:
extract-openxyos.cmdprinted系统找不到指定的批处理标签 - liveNodeOkand exited 1.node\node.exeand nestedopenxyos\dist\index.htmlwere already on disk; top-leveldist\index.htmlis not required.FreeOS-openXYOSwas created.probeOpenXYOSthen waited 60s forhttp://127.0.0.1:3780/api/health/livezand Aborted the whole install (exit 12 / error 68) before writing.install-ready. Port 3780 was not occupied — the old MessageBox was misleading.Root cause: the generated cmd wrote
liveNodeOk:butcmd.exeonly accepts:liveNodeOkas agototarget.This PR:
:liveNodeOkand ends extract withexit /b 0when LIVE hasnode\node.exeplusdist\index.htmloropenxyos\dist\index.html.FreeOS-openXYOStask once at 30s, then warn + continue (DetailPrint + information MessageBox). Does not blame a busy 3780 port..install-readyafter layout + autostart, before the livez wait, so Organization can start the sidecar later even if livez is still down.requireOpenXYOSLayout/ error 67).:liveNodeOkand noliveNodeOk:label, and that.install-readyis stamped before probe.Target branch
develop(feature / fix — default)main(this repo ships installer fixes tomain)Type of change
Test plan
uv run pytest tests/unit/desktop/test_nsis_uninstall.py -q— 16 passedmake lint+make typecheck— greenmake test— 3424 passed, 15 skipped (pre-stamp-move; NSIS tests re-run after)test_nsis_extract_cmd_uses_colon_prefixed_batch_labels; probe no longer Aborts / error 68;.install-readybefore probe)How to verify on Windows:
FreeOS-desktop-windows-amd64-*.exeelevated.系统找不到指定的批处理标签and should show extract exit 0 oncenode.exe+ nested or flatdist\index.htmlexist.%LOCALAPPDATA%\FreeOS\openxyos\.install-ready, HKCU RunFreeOS-openXYOS, and the logon task remain even when port 3780 never answered.Checklist
CHANGELOG.md(if user-facing)