Repository navigation
Fix Chat dock tasks i18n call that breaks tsc - #42
Merged
Merged
Conversation
apiErrorMessage expects a fallback string then optional t; passing t as the second argument failed dashboard typecheck and blocked Windows packaging. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatDockTasksContentpassed the i18ntfunction asapiErrorMessage's fallback string. That is aTFunction, sotsc -b/make build-frontendfails:This blocks FreeOS Desktop Package (Windows packaging).
Change
Call
apiErrorMessage(err, fallback, t)like every other dashboard site:t("chat.rightRail.tasksLoadFailed", "加载任务失败")tAdded matching
chat.rightRail.tasksLoadFailedkeys inen.json/zh.json. Grep found no otherapiErrorMessage(..., t)siblings.Target branch
main(hotfix for packaging-blocking build break after 开发空间：可折叠右侧栏与对话权限模式 #39/Fix registered local models missing from the chat picker #40)Type of change
Test plan
cd dashboard && npx tsc --noEmit— passcd dashboard && npx tsc -b— passcd dashboard && npm run build(tsc -b && vite build) — passchat.rightRailen/zh key trees match (tasksLoadFailedpresent in both)make build-frontendlocally isnpm ci+npm run build; the typecheck/build half is already green. Desktop Package CI only runs ondesktop/**/openxyos/**path filters, so this dashboard-only PR does not trigger that workflow.