feat: add configurable tooltip position and offsets#54
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds configurable tooltip positioning to resolve tooltip overlap issues. A new tooltip settings table in SavedVariables schema captures position type and X/Y offsets. A new ChangesTooltip Positioning Configuration
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Adds configurable positioning for the PhDamage companion tooltip frame.
Why
The tooltip was hardcoded to anchor below GameTooltip (
SetPoint("TOPLEFT", GameTooltip, "BOTTOMLEFT", 0, -4)), causing overlap when the default game tooltip is positioned at the bottom-right of the screen.Changes
tooltipdefaults (position,offsetX,offsetY) to DB defaults; callsns.Tooltip.ApplySettings()inOnInitializeSetPointwithPOSITION_MAP-driven anchoring viaApplySettings(); reads from AceDB profileReview
Both reviewer passes completed clean. Defaults preserve old behavior.
Closes #53
Summary by CodeRabbit
Release Notes