feat(desktop): add guided capture and compare workflow - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en-USandzh-CNUI, a real Windows dogfood screenshot, source-build documentation, dependency updates, and desktop CICloses #13.
Product and security boundaries
Local validation
-D warnings: passed-D warnings: passed--no-bundlerelease build: passed; PE32+ Windows GUI subsystem verifiedgit diff --check: passedReal Windows dogfood
A real release GUI session completed the product path without PowerShell, JSON, a file picker, or manual Snapshot names: GUI Start capture → separately gated synthetic
HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\RunvalueSystemDiffDogfood→ GUI Finish & Compare. The Results view classified exactly one Added startup entry, showed the exact synthetic command and location, showed no observed Service configuration changes, and preserved the partial Services coverage notice. Exact-data guarded Registry cleanup succeeded, the value was confirmed absent, and no session directory remained. The production desktop binary contains no write API.Independent review reports no remaining High or Medium findings.
Intentionally deferred
Desktop installer/bundle and artifact distribution, Authenticode signing, clean-machine WebView2 bootstrap, history/import/export, updater, Scheduled Tasks, rules/risk, redaction/sharing, and additional Collectors remain out of scope.