Skip to content

SWUTILS-959: Add AER error information#39

Merged
dchadwic-xilinx merged 1 commit into
Xilinx-CNS:mainfrom
dchadwic-xilinx:SWUTILS-959
Oct 6, 2025
Merged

SWUTILS-959: Add AER error information#39
dchadwic-xilinx merged 1 commit into
Xilinx-CNS:mainfrom
dchadwic-xilinx:SWUTILS-959

Conversation

@dchadwic-xilinx

@dchadwic-xilinx dchadwic-xilinx commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

This is a draft. Ultimately, there's some functionality I've added in the unmerged #31 and even #25 I'd like to pull in before this is done.

The output looks like this:
image

Information about the files we are monitoring: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats

EDIT: Output now looks like this:
image
image

@dchadwic-xilinx

Copy link
Copy Markdown
Collaborator Author

I think it's probably worth getting the 'fatal' AER errors highlighted an an "interesting value".

@dchadwic-xilinx dchadwic-xilinx force-pushed the SWUTILS-959 branch 3 times, most recently from f397aed to 315b856 Compare August 4, 2025 13:49
@dchadwic-xilinx

Copy link
Copy Markdown
Collaborator Author
image

This table is now hidden by default and also is passed through the interesting values check. I temporarily changed the check for non-fatal to look for ==0 instead for the pics.

image

@dchadwic-xilinx dchadwic-xilinx marked this pull request as ready for review August 4, 2025 13:51
@amitgu-xilinx

Copy link
Copy Markdown
Collaborator

@dchadwic-xilinx Thank you, looks good. Joby reported that the AER error he observed, but the counters were not incremented. You might need to check with him.

Also you mentioned earlier that "rasdaemon" service must be running to collect the logs using PCI.
If so, have you tried the following way to read the AER counters?
"cat /sys/bus/pci/devices/0000:42:00.0/aer_dev_*" maha shared the following command to check AER stats.

@ibeecraft-amd ibeecraft-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the interesting values sections to be a little better at highlighting either interface names or PCI IDs but as it has always been this way, I'm happy for this change to go in.

Maybe later we can modify the interesting values section.

@amitgu-xilinx

Copy link
Copy Markdown
Collaborator

As we discussed, please also report the PCIe device address in the " interesting values" section.

@dchadwic-xilinx

Copy link
Copy Markdown
Collaborator Author

I would like the interesting values sections to be a little better at highlighting either interface names or PCI IDs but as it has always been this way, I'm happy for this change to go in.

I've scoped this and it won't be so simple with the current way that tabulate() works. By the time it's comparing values, it doesn't have the context anymore. This is something that could change but this PR should not be blocked by it.

@dchadwic-xilinx

dchadwic-xilinx commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

By the time it's comparing values, it doesn't have the context anymore.

That being said - I've found a solution which pipes it though and gives this output:
image

@amitgu-xilinx @ibeecraft-amd does this meet your requirement? If so - I'll update the PR.

@dchadwic-xilinx

Copy link
Copy Markdown
Collaborator Author

This has also been improved to grab the full list of error numbers:
image
image

@dchadwic-xilinx dchadwic-xilinx merged commit b81f9f6 into Xilinx-CNS:main Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants