SWUTILS-978: detect non-functional sfboot configuration (ultra-low-latency + partitioning)#49
Open
andresa-xilinx wants to merge 1 commit into
Open
SWUTILS-978: detect non-functional sfboot configuration (ultra-low-latency + partitioning)#49andresa-xilinx wants to merge 1 commit into
andresa-xilinx wants to merge 1 commit into
Conversation
…tency + partitioning) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
When an X2 NIC has ultra-low-latency firmware variant with partitioning switch mode, the configuration is non-functional — partitioning requires the full-feature firmware variant. In Onload 8 this misconfiguration was silently tolerated (sockets fell back to
kernel), but since Onload 9 (ON-14517, commit 1f560abeb4) it causes
-EFILTERSSOME (-122)filter insertion failures that tear down all HW filters, leaving sockets with zero acceleration.sfboot itself warns when setting partitioning interactively, but if the user changes the firmware variant afterward, no warning is emitted. This makes the issue expensive to triage in the field.
Changes
Parses sfboot output per-interface after it is printed, extracts Firmware variant and Switch mode, and pushes an interest_error when the incompatible combination is detected. The error message includes the remediation command (
sfboot -i <iface> firmware-variant=full-feature) and notes that a cold reboot is required.Report after the proposed change:
Report on the summary of interesting values: