ON-16037: added functions to read stats for interfaces#52
Open
rdrinkwa-xilinx wants to merge 1 commit into
Open
ON-16037: added functions to read stats for interfaces#52rdrinkwa-xilinx wants to merge 1 commit into
rdrinkwa-xilinx wants to merge 1 commit into
Conversation
ligallag-amd
requested changes
Nov 11, 2024
ligallag-amd
left a comment
Contributor
There was a problem hiding this comment.
I think you need to make static method which does the following.
pthread_mutex_lock(&printf_mutex);
printf(...)
pthread_mutex_unlock(&printf_mutex);There is too much duplicated code. Please update #50 to do this also.
4b95caa to
5723af0
Compare
pemberso-xilinx
suggested changes
Nov 13, 2024
5723af0 to
159dd3b
Compare
pemberso-xilinx
suggested changes
Nov 28, 2024
159dd3b to
68f5a4d
Compare
cb554e6 to
3ec4c58
Compare
ligallag-amd
approved these changes
Jan 28, 2025
3ec4c58 to
aac084b
Compare
aac084b to
8c7da63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two functions to read the drop stats from the physical interfaces used by TCPDirect. Tested as working with physical interfaces themselves or a bond. The zfsink app was updated to make use of this additional functionality for testing and demo purposes.
The design mimics that of ef_vi itself with the two calls to get the layout and then the actual stats themselves. It could be changed to hold a copy of the layout internally within the stack so passing it back in wouldn't be required but it would add complexity and necessitate code changes in other files beyond the minimal updates to existing files here.
Testing with 'efsend' sending 1000 1-byte packets as a burst that is known to exceed zfsink's ability to avoid drops.