Skip to content

Remove duplicated command_config.py file#101

Open
taraxacum45e9a wants to merge 1 commit into
Xilinx:devfrom
taraxacum45e9a:dev
Open

Remove duplicated command_config.py file#101
taraxacum45e9a wants to merge 1 commit into
Xilinx:devfrom
taraxacum45e9a:dev

Conversation

@taraxacum45e9a
Copy link
Copy Markdown

The file (linker/slashkit/command_config.py) is exactly the same as (linker/slashkit/core/command_config.py), and only the one under core is actually used.

This PR removes the file linker/slashkit/command_config.py which is duplicated and unused.

Details
$ shasum linker/slashkit/command_config.py linker/slashkit/core/command_config.py
1d6e15d36a6fd964e973d6ecb0b6538ff34796bd  linker/slashkit/command_config.py
1d6e15d36a6fd964e973d6ecb0b6538ff34796bd  linker/slashkit/core/command_config.py

$ rg command_config       
linker/slashkit/__main__.py
40:from slashkit.core.command_config import LinkerConfiguration, Platform, InstallerConfiguration, CommandConfiguration

linker/slashkit/emit/emu/project_gen.py
35:from slashkit.core.command_config import LinkerConfiguration

linker/slashkit/emit/emu/tcl_gen.py
31:from slashkit.core.command_config import LinkerConfiguration

linker/slashkit/emit/hw/project_gen.py
35:from slashkit.core.command_config import LinkerConfiguration, InstallerConfiguration, CommandConfiguration

linker/slashkit/emit/hw/tcl_gen.py
44:from slashkit.core.command_config import LinkerConfiguration

linker/slashkit/emit/sim/project_gen.py
30:from slashkit.core.command_config import LinkerConfiguration

linker/slashkit/emit/sim/tcl_gen.py
33:from slashkit.core.command_config import LinkerConfiguration

linker/slashkit/emit/metadata/prog_image.py
26:from slashkit.core.command_config import LinkerConfiguration

Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
@taraxacum45e9a taraxacum45e9a force-pushed the dev branch 2 times, most recently from 5b63896 to d13f3b9 Compare May 30, 2026 11:28
taraxacum45e9a added a commit to taraxacum45e9a/SLASH that referenced this pull request Jun 1, 2026
Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant