Skip to content

Ask on package rebuild#67

Merged
hpc-aulmamei merged 2 commits into
Xilinx:devfrom
amd-vserbu:feature/rm-ask
Apr 22, 2026
Merged

Ask on package rebuild#67
hpc-aulmamei merged 2 commits into
Xilinx:devfrom
amd-vserbu:feature/rm-ask

Conversation

@amd-vserbu
Copy link
Copy Markdown
Collaborator

The package-deb.sh and package-rpm.sh scripts run a full clean build, including the static shell, starting by removing any previous build.

This patch asks the user if they really want to run the rebuild, to prevent accidental removals.

If the script is run non-interactively (stdin is not a terminal), this question is skipped.

This patch also adds early checks for v++ in path (Vivado/Vitis sourced) and for the smbus, so that the build fails early with descriptive errors if the user has not satisfied the prerequisites for build.

Signed-off-by: Vlad-Gabriel Serbu <Vlad-Gabriel.Serbu@amd.com>
@JOOpdenhoevel
Copy link
Copy Markdown
Collaborator

I would advocate for an explicit "non-interactive" or "always say yes" option. You never know in what kinds of situations such a script is executed, so only using the test -t check might lead to situations where the script is actually executed non-interactively, but it doesn't look like it.

Signed-off-by: Vlad-Gabriel Serbu <Vlad-Gabriel.Serbu@amd.com>
@amd-vserbu
Copy link
Copy Markdown
Collaborator Author

@JOOpdenhoevel Fair enough. Added --noninteractive to the scripts.

@JOOpdenhoevel
Copy link
Copy Markdown
Collaborator

LGTM

@hpc-aulmamei
Copy link
Copy Markdown
Collaborator

lgtm. merging

@hpc-aulmamei hpc-aulmamei merged commit f54ce39 into Xilinx:dev Apr 22, 2026
1 check passed
@amd-vserbu amd-vserbu deleted the feature/rm-ask branch May 12, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants