AIESW-871: Adding df_bw support(AIESW-6825)#41
Conversation
Improvements to df-bw tests - Added new .elf file to transfer 1GB as xrt-smi expected 1GB trasnfer - The iterations are reduced to 100 - Initialize output buffer with 0 - ignore the constat which is unnecessary
There was a problem hiding this comment.
Pull request overview
This PR enhances the df-bw (data fabric bandwidth) test by updating the test configuration and binary to meet xrt-smi validation requirements for 1GB data transfer.
Key Changes:
- Updated test binary (df_bw.elf) to support 1GB data transfer
- Reduced test iterations from 600 to 100 for faster execution
- Added output buffer initialization with zero values
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| recipe_df_bandwidth.json | Removed unnecessary constants array from kernel arguments |
| profile_df_bandwidth.json | Added ofm buffer initialization and reduced iterations from 600 to 100 |
| df_bw.elf | Updated binary with new oid and increased size from 38544 to 165392 bytes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
| ], | ||
| "execution" : { |
There was a problem hiding this comment.
The PR description mentions reducing iterations to 100, but doesn't explain why this value was chosen or how it relates to the 1GB transfer requirement. Consider adding a comment explaining the relationship between iterations, buffer size, and total data transferred.
| "execution" : { | |
| "execution" : { | |
| // _comment: With a buffer size of 1GB (1073741824 bytes) and 100 iterations, the total data transferred is 100GB. The number of iterations was chosen to achieve a total transfer of 100GB for bandwidth profiling. |
There was a problem hiding this comment.
Not sure if we can comment these json files
| }, | ||
| { | ||
| "name" : "ofm", | ||
| "size" : 1073741824, |
There was a problem hiding this comment.
The size value 1073741824 is a magic number. Consider adding a comment indicating this is 1GB (102410241024 bytes) to improve readability and match the PR description's reference to '1GB transfer'.
There was a problem hiding this comment.
size is 1073741824 because the elf transfers 1GB data thus allocated 1GB buffer
AIESW-871
AIESW-6825
Improvements to df-bw tests