Skip to content

AIESW-871: Adding df_bw support(AIESW-6825)#41

Merged
aktondak merged 1 commit intoXilinx:mainfrom
sandilya-xilinx:df-bw
Dec 16, 2025
Merged

AIESW-871: Adding df_bw support(AIESW-6825)#41
aktondak merged 1 commit intoXilinx:mainfrom
sandilya-xilinx:df-bw

Conversation

@sandilya-xilinx
Copy link
Contributor

@sandilya-xilinx sandilya-xilinx commented Dec 16, 2025

AIESW-871
AIESW-6825
Improvements to df-bw tests

  • Added new .elf file to transfer 1GB as xrt-smi expected 1GB trasnfer
  • The iterations are reduced to 100
  • Initialize output buffer with 0
  • ignore the constat which is unnecessary
C:\sandilya_work>xrt-smi validate --advanced -r df-bw --verbose
Verbose: Enabling Verbosity
-------------------------------------------------------------------------
                    DISCLAIMER  (xrt-smi --advanced)
You are running a developer command that may change system configuration.
                Continue only if you understand the risks.
-------------------------------------------------------------------------
Verbose: Setting power mode to `performance`

Validate Device           : [00c6:00:01.1]
    Platform              : NPU Medusa
    Power Mode            : Performance
-------------------------------------------------------------------------------
Test 1 [00c6:00:01.1]     : df-bw
    Description           : Run bandwidth test on data fabric
    Details               : Total duration: 3.9s
                            Average bandwidth per shim DMA: 51.5 GB/s
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed

C:\sandilya_work>

Improvements to df-bw tests
- Added new .elf file to transfer 1GB as xrt-smi expected 1GB trasnfer
- The iterations are reduced to 100
- Initialize output buffer with 0
- ignore the constat which is unnecessary
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the df-bw (data fabric bandwidth) test by updating the test configuration and binary to meet xrt-smi validation requirements for 1GB data transfer.

Key Changes:

  • Updated test binary (df_bw.elf) to support 1GB data transfer
  • Reduced test iterations from 600 to 100 for faster execution
  • Added output buffer initialization with zero values

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
recipe_df_bandwidth.json Removed unnecessary constants array from kernel arguments
profile_df_bandwidth.json Added ofm buffer initialization and reduced iterations from 600 to 100
df_bw.elf Updated binary with new oid and increased size from 38544 to 165392 bytes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}
}
],
"execution" : {
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions reducing iterations to 100, but doesn't explain why this value was chosen or how it relates to the 1GB transfer requirement. Consider adding a comment explaining the relationship between iterations, buffer size, and total data transferred.

Suggested change
"execution" : {
"execution" : {
// _comment: With a buffer size of 1GB (1073741824 bytes) and 100 iterations, the total data transferred is 100GB. The number of iterations was chosen to achieve a total transfer of 100GB for bandwidth profiling.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we can comment these json files

},
{
"name" : "ofm",
"size" : 1073741824,
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size value 1073741824 is a magic number. Consider adding a comment indicating this is 1GB (102410241024 bytes) to improve readability and match the PR description's reference to '1GB transfer'.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size is 1073741824 because the elf transfers 1GB data thus allocated 1GB buffer

@aktondak aktondak merged commit 4c9964d into Xilinx:main Dec 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants