AIESW-26143 Disclaimer should not show up on non-hidden commands#9636
Open
rchane wants to merge 4 commits intoXilinx:masterfrom
Open
AIESW-26143 Disclaimer should not show up on non-hidden commands#9636rchane wants to merge 4 commits intoXilinx:masterfrom
rchane wants to merge 4 commits intoXilinx:masterfrom
Conversation
Signed-off-by: Ryan Chane <rchane@xilinx.com>
Signed-off-by: Ryan Chane <rchane@xilinx.com>
rchane
requested review from
AShivangi,
chvamshi-xilinx and
rozumx
as code owners
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Ryan Chane <rchane@xilinx.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Ryan Chane <rchane@xilinx.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://jira.xilinx.com/browse/AIESW-26143
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Update to AIESW-3442, discovered during bash testing.
How problem was solved, alternative solutions (if any) and why they were rejected
Checked hidden options. Disclaimer will not show up when purely non-hidden commands/options are run. Disclaimer will not show up in help menu. Also updated logic of configuration to use default smi config in the case a device query failed.
In addition, including a change to architecture output in examine report that was requested during review.
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
Tested on KRK machine.
Documentation impact (if any)
N/A