zynqmp: Fix release-then-use segfault on bootimage import#50
Open
bradfa wants to merge 1 commit into
Open
Conversation
The v2026.1 smart-pointer migration replaced raw pointers with unique_ptr, but two spots kept dereferencing a unique_ptr after calling release() on it to hand ownership to a std::list. release() nulls the unique_ptr, so the subsequent field reads deref a null pointer and crash. This regressed `bootgen -arch zynqmp -image <bif>` when the BIF contains a [bootimage] partition (e.g. presigned-FSBL flows using -generate_hashes), which worked in v2025.1 with raw pointers. Signed-off-by: Andrew Bradford <andrew.bradford@konsulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2026.1 smart-pointer migration replaced raw pointers with unique_ptr, but two spots kept dereferencing a unique_ptr after calling release() on it to hand ownership to a std::list. release() nulls the unique_ptr, so the subsequent field reads deref a null pointer and crash.
This regressed
bootgen -arch zynqmp -image <bif>when the BIF contains a [bootimage] partition (e.g. presigned-FSBL flows using -generate_hashes), which worked in v2025.1 with raw pointers.