zynqmp: Fix null pHT segfault verifying partition-only images#51
Open
bradfa wants to merge 1 commit into
Open
Conversation
VerifyHeaderTableSignature() segfaulted on images with no bootloader partition (boot header sourceOffset == 0), such as a standalone signed FIT/Linux partition. That branch computed the signed header-block size from the pHT member, but ReadHeaderTableDetails() release()s each partition-header-table into the pHTs list, leaving pHT null. Normal bootloader images take the sourceOffset != 0 branch and never hit this, which is why it only showed up on partition-only images. Signed-off-by: Andrew Bradford <andrew.bradford@konsulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VerifyHeaderTableSignature() segfaulted on images with no bootloader partition (boot header sourceOffset == 0), such as a standalone signed FIT/Linux partition. That branch computed the signed header-block size from the pHT member, but ReadHeaderTableDetails() release()s each partition-header-table into the pHTs list, leaving pHT null. Normal bootloader images take the sourceOffset != 0 branch and never hit this, which is why it only showed up on partition-only images.